Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: request.Clone doesn't deep copy TransferEncoding [1.14 backport] #41913

Closed
gopherbot opened this issue Oct 10, 2020 · 3 comments
Closed

net/http: request.Clone doesn't deep copy TransferEncoding [1.14 backport] #41913

gopherbot opened this issue Oct 10, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.11

Comments

@gopherbot
Copy link

@odeke-em requested issue #41907 to be considered for backport to the next 1.14 minor release.

Thank you for catching this @dqu123 and welcome to the Go project! Good eyes.

@gopherbot please backport this issue.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 10, 2020
@gopherbot gopherbot mentioned this issue Oct 10, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.10 milestone Oct 10, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/261377 mentions this issue: [release-branch.go1.14] net/http: deep copy Request.TransferEncoding

@toothrot toothrot modified the milestones: Go1.14.10, Go1.14.11 Oct 14, 2020
@cagedmantis
Copy link
Contributor

Approved as this is an issue without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Oct 22, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 22, 2020
gopherbot pushed a commit that referenced this issue Oct 23, 2020
@dqu123 @cagedmantis
[release-branch.go1.14] net/http: deep copy Request.TransferEncoding
3109de2 
The existing implementation in Request.Clone() assigns the wrong
pointer to r2.TransferEncoding.

Updates #41907.
Fixes #41913.

Change-Id: I7f220a41b1b46a55d1a1005e47c6dd69478cb025
Reviewed-on: https://go-review.googlesource.com/c/go/+/261377
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Trust: Emmanuel Odeke <emm.odeke@gmail.com>
@gopherbot
Copy link
Author

Closed by merging 3109de2 to release-branch.go1.14.

@golang golang locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.11
Development

No branches or pull requests
3 participants
@toothrot @cagedmantis @gopherbot