Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev.go2go: please rebase against master or at least 1.15. #41909

Closed
OneOfOne opened this issue Oct 10, 2020 · 5 comments
Closed

dev.go2go: please rebase against master or at least 1.15. #41909

OneOfOne opened this issue Oct 10, 2020 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@OneOfOne
Copy link
Contributor

I used to manually rebase it but the changes are a bit too much atm.
@ianlancetaylor
Copy link
Contributor

CC @griesemer

@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 11, 2020
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Oct 11, 2020
@griesemer
Copy link
Contributor

As this is a prototype and we wanted to keep a clean history of changes, in the past I have simply rebased the entire sequence of commits on top of master, and then rewritten the history in the repo.

Is this still acceptable?

@OneOfOne
Copy link
Contributor Author

@griesemer Yep that would be perfect.

@griesemer
Copy link
Contributor

Just FYI: This may happen as needed; but it's not urgent as this branch is just a prototype.

@OneOfOne
Copy link
Contributor Author

Yeah completely understandable, I have no problem rebasing it myself most of the time but around the 1.15 release something major changed and I just couldn't get it to compile at all.

@golang golang locked and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@OneOfOne @ianlancetaylor @griesemer @gopherbot