Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

access: Approver Access ("approvers") #41898

Closed
mengzhuo opened this issue Oct 10, 2020 · 5 comments
Closed

access: Approver Access ("approvers") #41898

mengzhuo opened this issue Oct 10, 2020 · 5 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Backlog

Comments

@mengzhuo
Copy link
Contributor

mengzhuo commented Oct 10, 2020 •
edited

Gerrit email: mzh@golangcn.org

Approver Access ("approvers")

https://go-review.googlesource.com/#/admin/groups/1005,members

Hi, @dmitshur

I need approver access some well test CLs takes too long to submit (i.e. https://go-review.googlesource.com/c/go/+/180757)
@cherrymui
Copy link
Member

@mengzhuo sorry for the delay. Please ping me if a CL does not get a response for ~a week. Thanks.

@mengzhuo
Copy link
Contributor Author

@mengzhuo sorry for the delay. Please ping me if a CL does not get a response for ~a week. Thanks.

Hi, Cherry
I just wish that I can take the load off for you :)

@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 13, 2020
@dmitshur
Copy link
Contributor

Thank you for making the request @mengzhuo, we will consider it.

@dmitshur dmitshur removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 13, 2020
@benshi001
Copy link
Member

Mengzhou has been around for a long time, and made many commits.

I think he need not two +2 votes for his future CLs, so giving him the approver access can simplify his future work.

Actually I am an approver but less use my access.

@cagedmantis cagedmantis added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 19, 2020
@cagedmantis cagedmantis added this to the Backlog milestone Oct 19, 2020
@toothrot
Copy link
Contributor

You're good to go. Thanks for your contributions!

@toothrot toothrot self-assigned this Oct 21, 2020
@golang golang locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@toothrot @cagedmantis @mengzhuo @dmitshur @gopherbot @cherrymui @benshi001