Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/internal/dl: serve .sha256 checksum files by redirecting to https://dl.google.com/go #41894

Open
owenthereal opened this issue Oct 9, 2020 · 1 comment
Open

x/website/internal/dl: serve .sha256 checksum files by redirecting to https://dl.google.com/go #41894

owenthereal opened this issue Oct 9, 2020 · 1 comment
Assignees
@dmitshur
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Unreleased

Comments

@owenthereal
Copy link

owenthereal commented Oct 9, 2020 •
edited

What version of Go are you using (go version)?

golang/website#24

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

The download of a Go release redirects to https://dl.google.com/go but the download of the same release's sh256 checksum does not.

For example:

$ curl https://golang.org/dl/go1.15.2.linux-amd64.tar.gz
<a href="https://dl.google.com/go/go1.15.2.linux-amd64.tar.gz">Found</a>.

$ curl https://golang.org/dl/go1.15.2.linux-amd64.tar.gz.sha256
<!DOCTYPE html>
<html>
<head>
<meta name="go-import" content="golang.org/dl git
https://go.googlesource.com/dl">
<meta http-equiv="refresh" content="0;
url=https://golang.org/dl/#go1.15.2.linux-amd64.tar.gz.sha256">
</head>
<body>
Nothing to see here; <a
href="https://golang.org/dl/#go1.15.2.linux-amd64.tar.gz.sha256">move
along</a>.
</body>
</html>

The sha256 URL is available at https://dl.google.com/go by appending .sha256 to the end of a release:

$ curl https://dl.google.com/go/go1.15.2.linux-amd64.tar.gz.sha256
b49fda1ca29a1946d6bb2a5a6982cf07ccd2aba849289508ee0f9918f6bb4552

To summarize,

  1. ✔️ curl https://golang.org/dl/go1.15.2.linux-amd64.tar.gz -> https://dl.google.com/go/go1.15.2.linux-amd64.tar.gz
  2. 🚫 curl https://golang.org/dl/go1.15.2.linux-amd64.tar.gz.sha256 -> curl https://dl.google.com/go/go1.15.2.linux-amd64.tar.gz.sha256
  3. ✔️ curl https://dl.google.com/go/go1.15.2.linux-amd64.tar.gz
  4. ✔️ curl https://dl.google.com/go/go1.15.2.linux-amd64.tar.gz.sha256

What did you expect to see?

It would be nice that a release's sha256 can be redirected from https://golang.org/dl to https://dl.google.com/go, the same as its corresponding release. This makes the download of a release and its checksum both accessible from https://golang.org/dl.

What did you see instead?

The download of a release's checksum is not possible from the host https://golang.org/dl.
@gopherbot gopherbot added this to the Proposal milestone Oct 9, 2020
@owenthereal
Copy link
Author

I took a stab at supporting this: golang/website#24. PTAL.

@owenthereal owenthereal changed the title proposal: x/website/internal/dl: Redirect sha256 checksum to https://dl.google.com/go x/website: Redirect sha256 checksum to https://dl.google.com/go Oct 9, 2020
@dmitshur dmitshur self-assigned this Oct 10, 2020
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Proposal labels Oct 10, 2020
@dmitshur dmitshur modified the milestones: Proposal, Unreleased Oct 10, 2020
@dmitshur dmitshur changed the title x/website: Redirect sha256 checksum to https://dl.google.com/go x/website/internal/dl: serve .sha256 checksum files by redirecting to https://dl.google.com/go Apr 16, 2022
@dmitshur dmitshur added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 16, 2022
@dmitshur dmitshur mentioned this issue Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@owenthereal @dmitshur @gopherbot