Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: support other GOARCH values in 1.15 [1.15 backport] #41871

Closed
ianlancetaylor opened this issue Oct 8, 2020 · 3 comments
Closed

cmd/cgo: support other GOARCH values in 1.15 [1.15 backport] #41871

ianlancetaylor opened this issue Oct 8, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.3

Comments

@ianlancetaylor
Copy link
Contributor

This is a request to add https://golang.org/cl/260657 to 1.15. This will help adding gccgo support in golang.org/x/sys/unix for architectures that are supported by gccgo but not gc.

    cmd/cgo: add more architectures to size maps
    
    This brings over the architectures that the gofrontend knows about.
    This permits using the main cgo tool for those architectures,
    as cgo can be used with -godefs without gc support.
    This will help add golang.org/x/sys/unix support for other architectures.
    
    For #37443
@ianlancetaylor ianlancetaylor added the CherryPickCandidate Used during the release process for point releases label Oct 8, 2020
@ianlancetaylor ianlancetaylor added this to the Go1.15.3 milestone Oct 8, 2020
@gopherbot
Copy link

Change https://golang.org/cl/260702 mentions this issue: [release-branch.go1.15] cmd/cgo: add more architectures to size maps

@dmitshur dmitshur changed the title cmd/cgo: support other GOARCH values in 1.15 cmd/cgo: support other GOARCH values in 1.15 [1.15 backport] Oct 8, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2020

Approving per discussion in a release meeting.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 8, 2020
@gopherbot
Copy link

Closed by merging 2c2e11f to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Oct 8, 2020
@ianlancetaylor
[release-branch.go1.15] cmd/cgo: add more architectures to size maps
2c2e11f 
This brings over the architectures that the gofrontend knows about.
This permits using the main cgo tool for those architectures,
as cgo can be used with -godefs without gc support.
This will help add golang.org/x/sys/unix support for other architectures.

For #37443
Fixes #41871

Change-Id: I63632b9c5139e71b9ccab8edcc7acdb464229b74
Reviewed-on: https://go-review.googlesource.com/c/go/+/260657
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit 5d13781)
Reviewed-on: https://go-review.googlesource.com/c/go/+/260702
claucece pushed a commit to claucece/go that referenced this issue Oct 22, 2020
@ianlancetaylor @claucece
[release-branch.go1.15] cmd/cgo: add more architectures to size maps
07f4a23 
This brings over the architectures that the gofrontend knows about.
This permits using the main cgo tool for those architectures,
as cgo can be used with -godefs without gc support.
This will help add golang.org/x/sys/unix support for other architectures.

For golang#37443
Fixes golang#41871

Change-Id: I63632b9c5139e71b9ccab8edcc7acdb464229b74
Reviewed-on: https://go-review.googlesource.com/c/go/+/260657
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit 5d13781)
Reviewed-on: https://go-review.googlesource.com/c/go/+/260702
@golang golang locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.3
Development

No branches or pull requests
3 participants
@dmitshur @ianlancetaylor @gopherbot