Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: widen "Download" button on /doc/install page so text doesn't wrap excessively #41856

Closed
stevetraut opened this issue Oct 7, 2020 · 4 comments
Closed

x/website: widen "Download" button on /doc/install page so text doesn't wrap excessively #41856

stevetraut opened this issue Oct 7, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@stevetraut
Copy link

stevetraut commented Oct 7, 2020 •
edited by dmitshur

This is an issue requesting a change to documentation.

In the download button at https://golang.org/doc/install, the button text wraps, making it a little harder to read. Widening it a bit will give us two lines of unwrapped text for all three OSes.

Looks like changing the width value in the download class will work. It's currently 9.375rem -- it could be 16rem.

.download {
  width: 16rem;
}

@rsc @dmitshur
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@seankhliao
Copy link
Member

can you show a screenshot? are you using font scaling? because it looks fine (single line) for

@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2020

This is what https://golang.org/doc/install looks like at 100% scaling in Chrome on macOS for me:

image

With the suggested 16rem width:

image

Making it wider on the https://golang.org/doc/install page seems fine. We should take care that it doesn't affect other pages inadvertently (e.g., https://golang.org/dl/ also has buttons with the "download" class).

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 8, 2020
@dmitshur dmitshur changed the title x/website: Widen "Download" button so that text needn't wrap. x/website: widen "Download" button on /doc/install page so text needn't wrap excessively Oct 8, 2020
@stevetraut
Copy link
Author

The .download width style rule on https://golang.org/dl/ appears to be superseded by the .downloadBox width, which is set to 280px.

I suggest we change .download width to 17.5rem, which is equivalent to 280px. That will make the buttons on both pages the same width. Just in case.

@gopherbot
Copy link

Change https://golang.org/cl/260917 mentions this issue: content/static: widen download button to avoid wrapping.

@dmitshur dmitshur changed the title x/website: widen "Download" button on /doc/install page so text needn't wrap excessively x/website: widen "Download" button on /doc/install page so text doesn't wrap excessively Oct 9, 2020
@golang golang locked and limited conversation to collaborators Oct 16, 2021
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static: widen download button to avoid wrapping
06b39bf 
This change sets the width style rule for download buttons
so that label text in the button won't wrap excessively.
This should make it a little easier to read.

Fixes golang/go#41856

Change-Id: Icde39c68b10416963c9c1b493303818728488341
Reviewed-on: https://go-review.googlesource.com/c/website/+/260917
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Steve Traut <straut@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @stevetraut @gopherbot @seankhliao