Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error when building golang.org/x/text/internal/number at tip #41846

Closed
bcmills opened this issue Oct 7, 2020 · 2 comments
Closed

cmd/compile: internal compiler error when building golang.org/x/text/internal/number at tip #41846

bcmills opened this issue Oct 7, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.16

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 7, 2020

From https://build.golang.org/log/671679e6be3aa57b463f7fa294f5dc59ba4ec007:

# golang.org/x/text/internal/number
internal/number/decimal.go:353:19: internal compiler error: '(*Decimal).ConvertInt': two final stores - simultaneous live stores v40 = StaticCall <mem> {AuxCall{"".(*Decimal).ConvertFloat([*Decimal,0],[RoundingContext,8],[float64,24],[int,32])}} [40] v79 v90 = Store <mem> {*Decimal} v54 v8 v1

goroutine 35 [running]:
runtime/debug.Stack(0xd6ece0, 0xc00000e018, 0x0)
	/workdir/go/src/runtime/debug/stack.go:24 +0x9f
cmd/compile/internal/gc.Fatalf(0xc00111e200, 0x37, 0xc001111f20, 0x3, 0x3)
	/workdir/go/src/cmd/compile/internal/gc/subr.go:199 +0x1b0
cmd/compile/internal/gc.(*ssafn).Fatalf(0xc0011114d0, 0x16113000000003, 0xc77b5c, 0x31, 0xc00036aaa0, 0x2, 0x2)
	/workdir/go/src/cmd/compile/internal/gc/ssa.go:6982 +0x1a5
cmd/compile/internal/ssa.(*Func).Fatalf(...)
	/workdir/go/src/cmd/compile/internal/ssa/func.go:652
cmd/compile/internal/ssa.(*Block).Fatalf(...)
	/workdir/go/src/cmd/compile/internal/ssa/block.go:363
cmd/compile/internal/ssa.dse(0xc000fe0c60)
	/workdir/go/src/cmd/compile/internal/ssa/deadstore.go:67 +0xd14
cmd/compile/internal/ssa.Compile(0xc000fe0c60)
	/workdir/go/src/cmd/compile/internal/ssa/compile.go:96 +0x9cd
cmd/compile/internal/gc.buildssa(0xc0000cf760, 0x2, 0x0)
	/workdir/go/src/cmd/compile/internal/gc/ssa.go:465 +0xe1a
cmd/compile/internal/gc.compileSSA(0xc0000cf760, 0x2)
	/workdir/go/src/cmd/compile/internal/gc/pgen.go:319 +0x5d
cmd/compile/internal/gc.compileFunctions.func2(0xc000d53020, 0xc000d482b0, 0x2)
	/workdir/go/src/cmd/compile/internal/gc/pgen.go:384 +0x4d
created by cmd/compile/internal/gc.compileFunctions
	/workdir/go/src/cmd/compile/internal/gc/pgen.go:382 +0x129

This failure mode appears to have been introduced at CL 259203 (CC @dr2chase @cherrymui).
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Oct 7, 2020
@bcmills bcmills added this to the Go1.16 milestone Oct 7, 2020
@dr2chase dr2chase self-assigned this Oct 7, 2020
@dr2chase
Copy link
Contributor

dr2chase commented Oct 7, 2020

Almost certainly late call lowering.

@gopherbot
Copy link

Change https://golang.org/cl/260237 mentions this issue: cmd/compile: store call args in the call block

@golang golang locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
3 participants
@dr2chase @bcmills @gopherbot