Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Help remove the package github.com/viney-shih/goroutine #41844

Closed
viney-shih opened this issue Oct 7, 2020 · 5 comments
Closed

x/pkgsite: Help remove the package github.com/viney-shih/goroutine #41844

viney-shih opened this issue Oct 7, 2020 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone
pkgsite/package-r...

Comments

@viney-shih
Copy link

viney-shih commented Oct 7, 2020 •
edited

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/viney-shih/goroutine

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36

Screenshot

goroutines_package_·_pkg_go_dev

What did you do?

I am the author of pachage goroutines. Please help remove https://pkg.go.dev/github.com/viney-shih/goroutine I am going to register another package name for it.

What did you expect to see?

page https://pkg.go.dev/github.com/viney-shih/goroutine and it's related data in DB are removed

What did you see instead?

I am going to register goroutines but failed. I type the following command and returns as below.

❯ GOPROXY=https://proxy.golang.org GO111MODULE=on go get github.com/viney-shih/goroutines@v1.0.0
go: downloading github.com/viney-shih/goroutines v1.0.0
go get: github.com/viney-shih/goroutines@v1.0.0: parsing go.mod:
        module declares its path as: github.com/viney-shih/goroutine
                but was required as: github.com/viney-shih/goroutines
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@jba
Copy link
Contributor

jba commented Oct 7, 2020

Unfortunately our exclusion code will block github.com/viney-shih/goroutines if we exclude github.com/viney-shih/goroutine (it just looks for a prefix).

If you just change the go.mod of github.com/viney-shih/goroutines to have the same module path, that should fix your problem.

@jba jba self-assigned this Oct 7, 2020
@jba jba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 7, 2020
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Oct 7, 2020
@viney-shih
Copy link
Author

@jba I have got your point and fixed go.mod issue.

However, I got two docs now.
https://pkg.go.dev/github.com/viney-shih/goroutines and https://pkg.go.dev/github.com/viney-shih/goroutine

I want to keep goroutines version. Could you please remove https://pkg.go.dev/github.com/viney-shih/goroutine for me?

Thanks.

@jba
Copy link
Contributor

jba commented Oct 8, 2020

This requires changing our exclusion logic, so it's not a simple fix. I'll start working on it shortly.

@jba jba added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 8, 2020
@gopherbot
Copy link

Change https://golang.org/cl/262179 mentions this issue: internal/postgres: make exclusions work componentwise

gopherbot pushed a commit to golang/pkgsite that referenced this issue Oct 14, 2020
@jba
internal/postgres: make exclusions work componentwise
6583537 
Change the way excluded prefixes match paths to work by path component.

Previously prefix "bad" would exclude "bad", "badness" and "bad/ness".
This CL makes it exclude "bad" (an exact match) and "bad/ness"
(component suffix), but not "badness".

For golang/go#41844

Change-Id: I021d8a7ba8816e3d356f883313ffe3eb53ec717d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/262179
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@jba
Copy link
Contributor

jba commented Nov 2, 2020

Done.

@jba jba closed this as completed Nov 2, 2020
@hyangah hyangah added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label May 20, 2022
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Milestone
pkgsite/package-removal
Development

No branches or pull requests
5 participants
@hyangah @julieqiu @viney-shih @gopherbot @jba