Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: merge workspace folders into a single view by default #41842

Closed
stamblerre opened this issue Oct 7, 2020 · 1 comment
Closed

x/tools/gopls: merge workspace folders into a single view by default #41842

stamblerre opened this issue Oct 7, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
multi-module workspaces gopls on-deck

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Oct 7, 2020 •
edited

Because gopls has only supported one workspace folder per view until this point, many users are used to opening multiple workspace folders. Now that gopls supports multi-module workspaces, we should try to prefer to make one view as much as possible. If this causes problems for the user, they will either need to disable workspace module mode or create a gopls.mod configuration file.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Oct 7, 2020
@stamblerre stamblerre mentioned this issue Oct 7, 2020
Closed
@stamblerre stamblerre changed the title x/tools/gopls: coalesce workspace folders into a single view by default x/tools/gopls: merge workspace folders into a single view by default Oct 21, 2020
@stamblerre stamblerre added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 21, 2020
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
@findleyr
Copy link
Contributor

We decided not to do that. Users should have the flexibility of choosing multiple workspaces or a single workspace module. The go.work proposal makes this easier.

multi-module workspaces automation moved this from To Do to Done Jun 28, 2021
gopls on-deck automation moved this from To Do to Done Jun 28, 2021
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Jun 28, 2021
@golang golang locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
Done
multi-module workspaces
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr