Skip to content

x/tools/gopls: detect edge cases when building the workspace module #41841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stamblerre opened this issue Oct 7, 2020 · 1 comment
Closed

x/tools/gopls: detect edge cases when building the workspace module #41841

stamblerre opened this issue Oct 7, 2020 · 1 comment
Labels
FrozenDueToAge gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@stamblerre
Copy link
Contributor

For example: When two modules in the workspace have replace directives that point to different locations on disk, we can immediately return an error when building the workspace module. For any such obviously problematic cases, we should report clear and actionable errors.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Oct 7, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 7, 2020
@stamblerre stamblerre mentioned this issue Oct 7, 2020
Closed
@findleyr findleyr added the gopls/workspace Issues related to support for modules or multi-module workspaces. label May 10, 2022
@findleyr
Copy link
Member

findleyr commented Aug 2, 2022

Obsoleted by go.work support.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2022
@golang golang locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr