Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/dashboard: add linux-386-softfloat builder #41840

Closed
martisch opened this issue Oct 7, 2020 · 2 comments
Closed

x/build/dashboard: add linux-386-softfloat builder #41840

martisch opened this issue Oct 7, 2020 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder
Milestone
Unreleased

Comments

@martisch
Copy link
Contributor

martisch commented Oct 7, 2020

https://go-review.googlesource.com/c/go/+/260017 added GO386=softfloat.

It would be good to have a linux builder that checks all tests pass for softfloat on 386 (similar to the old GO386=387 builder).

Note that this is not asking to have a builder that checks that only non sse2 instructions are used which AFAIK isnt checked by the 387 builder either.

/cc @cagedmantis @toothrot @randall77 @dmitshur
@martisch martisch added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder labels Oct 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@dmitshur dmitshur self-assigned this Oct 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/260201 mentions this issue: dashboard: add linux-386-softfloat builder

gopherbot pushed a commit to golang/build that referenced this issue Oct 8, 2020
@dmitshur
dashboard: add linux-386-softfloat builder
0f5b1a7 
It's based on the linux-386-387 builder, but with GO386=softfloat
and Debian 9 (stretch) instead of Debian 8 (jessie).

Test it on a subset of golang.org/x repos (golang.org/x/crypto),
since that should provide sufficient test coverage.

For golang/go#41840.
For golang/go#41848.

Change-Id: Ida95fce198056a05c359ac5ab816c582bdd5930f
Reviewed-on: https://go-review.googlesource.com/c/build/+/260201
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/261097 mentions this issue: dashboard: remove known issue for GO386=softfloat builder

@golang golang locked and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@martisch @dmitshur @gopherbot