Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: plan for vendoring in multi-module workspaces #41838

Closed
stamblerre opened this issue Oct 7, 2020 · 1 comment
Closed

x/tools/gopls: plan for vendoring in multi-module workspaces #41838

stamblerre opened this issue Oct 7, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

As previously discussed, we have not yet accounted for modules that use vendoring in the workspace module design. As of https://golang.org/cl/259623, the workspace module will be enabled for modules that have vendor directories, but the vendor directories will be ignored.

@heschik investigated the possibility of creating a workspace module vendor directory by combining the vendor directories of all of the modules in the workspace, but this doesn't seem to be a feasible approach.

If we choose to simply ignore vendor directories, we must first resolve #41819. We might also consider using the default mode if we only detect one module in the workspace, as the workspace module will offer no advantage in that case.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Oct 7, 2020
@stamblerre stamblerre moved this from To Do to Assigned in multi-module workspaces Nov 11, 2020
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
@heschi heschi removed their assignment Apr 16, 2021
@stamblerre
Copy link
Contributor Author

This is now subsumed by the go.work proposal: #45713.

multi-module workspaces automation moved this from Assigned to Done Jun 28, 2021
gopls on-deck automation moved this from To Do to Done Jun 28, 2021
@stamblerre stamblerre removed this from Done in gopls on-deck Jun 28, 2021
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Jun 28, 2021
@golang golang locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
Development

No branches or pull requests

3 participants