Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: treat inconsistent vendoring like a diagnostic #41819

Closed
stamblerre opened this issue Oct 6, 2020 · 2 comments
Closed

x/tools/gopls: treat inconsistent vendoring like a diagnostic #41819

stamblerre opened this issue Oct 6, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

Rather than match on error messages, we can treat the inconsistent vendoring error like a diagnostic, similar to go mod tidy. It could have its own handle, generated by running go list -m. The keys would be the module's go.mod file and the vendor/modules.txt.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Oct 6, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 6, 2020
@gopherbot
Copy link

Change https://golang.org/cl/259623 mentions this issue: internal/lsp: default to workspace module mode even with vendor dirs

gopherbot pushed a commit to golang/tools that referenced this issue Oct 7, 2020
We were previously opting out of workspace module mode when any module
had vendor directories. While we still haven't decided how to handle
vendoring, it simplifies things to opt experimentalWorkspaceModule users
in to the workspace module mode when they have modules with vendoring.

Temporarily require default mode for the inconsistent vendoring test
(golang/go#41819).

Fixes golang/go#41725

Change-Id: Ifa494daea51a2a3bb2e6bc3026bfb9e8118d31a3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/259623
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@stamblerre stamblerre self-assigned this Oct 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/261737 mentions this issue: internal/lsp: change go mod vendor warning into a diagnostic

@golang golang locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants