Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: TestTxCannotCommitAfterRollback failures on windows-amd64-2008 builder [1.14 backport] #41815

Closed
gopherbot opened this issue Oct 6, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@dmitshur requested issue #38597 to be considered for backport to the next 1.14 minor release.

@gopherbot Please backport to Go 1.14. This is a fix for a flaky test. A flaky test makes release testing more difficult and less accurate.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 6, 2020
@gopherbot gopherbot added this to the Go1.14.10 milestone Oct 6, 2020
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Oct 6, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/259858 mentions this issue: [release-branch.go1.14] database/sql: de-flake TestTxCannotCommitAfterRollback

@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2020

Approving per discussion in a release meeting. Only Go 1.14 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 8, 2020
@gopherbot
Copy link
Author

Closed by merging eadc935 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Oct 8, 2020
…rRollback

Do not cancel rows during test. Only cancel the Tx.
Correct the referenced issue number on the test.

Updates #38597.
Fixes #41815.

Change-Id: I0e8ba1bf2a8ba638d121c9c6938501fec1d5e961
Reviewed-on: https://go-review.googlesource.com/c/go/+/229478
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit ed7888a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/259858
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants