Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: change GetNestedModules to return nested modules for series #41802

Closed
julieqiu opened this issue Oct 5, 2020 · 3 comments
Closed

x/pkgsite: change GetNestedModules to return nested modules for series #41802

julieqiu opened this issue Oct 5, 2020 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

julieqiu commented Oct 5, 2020

At the moment, GetNestedModules figures out which nested modules to return using the module_path. However, this means that modules will not be returned when the major version is v2 or higher.

For example, GetNestedModules(ctx, "golang.org/x/tools/v2") will not return golang.org/x/tools/gopls and it should.
@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. labels Oct 5, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 5, 2020
@trongbq
Copy link

trongbq commented Oct 6, 2020

@julieqiu I will work on this one.

@julieqiu
Copy link
Member Author

julieqiu commented Oct 6, 2020

Thanks, @trongbq!

@gopherbot
Copy link

Change https://golang.org/cl/260277 mentions this issue: internal/postgres/details: GetNestedModules supports input paths which have major version

@golang golang locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@julieqiu @trongbq @gopherbot