Skip to content

x/text: printer.Printf works but printer.Print does not (all variants of print/printf) #41781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kalbasit opened this issue Oct 4, 2020 · 5 comments
Closed

x/text: printer.Printf works but printer.Print does not (all variants of print/printf) #41781

kalbasit opened this issue Oct 4, 2020 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@kalbasit
Copy link

kalbasit commented Oct 4, 2020

When using the message printer, I can translate fine with the Printf variants (Sprintf, Fprintf, Printf) but I don't get the translation for the Print variants (Sprint, Fprint, Print).

What version of Go are you using (go version)?

$ go version
go version go1.14.7 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/yl/.cache/go/cache"
GOENV="/yl/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/yl/.cache/ktmr/go:/yl/.cache/go/path"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/nix/store/y456vnv1032n1fx4bmh1b54m2br4c6jq-go-1.14.7/share/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/nix/store/y456vnv1032n1fx4bmh1b54m2br4c6jq-go-1.14.7/share/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/yl/code/stories/keeptruckin/SLB-962/github.com/KeepTruckin/kt/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-static-libstdc++"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/run/user/2000/go-build560714827=/tmp/go-build -gno-record-gcc-switches"

What did you do?

The following code is also available on the playground: https://play.golang.org/p/FHjZ3a8ug51

package main

import (
	"fmt"

	"golang.org/x/text/language"
	"golang.org/x/text/message"
)

func init() {
	message.SetString(language.English, "Book Now", "Book Now")
	message.SetString(language.French, "Book Now", "Réserver Maintenant")
	message.SetString(language.Spanish, "Book Now", "Reserve Ahora")
}

func main() {
	tags := []language.Tag{language.English, language.French, language.Spanish}

	for _, tag := range tags {
		p := message.NewPrinter(tag)
		fmt.Printf("==== %s ====\n", tag)

		fmt.Print("p.Print(\"Book Now\"): ")
		p.Print("Book Now")
		fmt.Println("")

		fmt.Print("p.Printf(\"Book Now\"): ")
		p.Printf("Book Now")
		fmt.Println("")
	}
}

What did you expect to see?

==== en ====
p.Print("Book Now"): Book Now
p.Printf("Book Now"): Book Now
==== fr ====
p.Print("Book Now"): Réserver Maintenant
p.Printf("Book Now"): Réserver Maintenant
==== es ====
p.Print("Book Now"): Reserve Ahora
p.Printf("Book Now"): Reserve Ahora

What did you see instead?

==== en ====
p.Print("Book Now"): Book Now
p.Printf("Book Now"): Book Now
==== fr ====
p.Print("Book Now"): Book Now
p.Printf("Book Now"): Réserver Maintenant
==== es ====
p.Print("Book Now"): Book Now
p.Printf("Book Now"): Reserve Ahora

@kaskavalci mentioned this problem in #26767 (comment)

cc @mpvl
@gopherbot gopherbot added this to the Unreleased milestone Oct 4, 2020
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 13, 2020
AlexanderYastrebov added a commit to AlexanderYastrebov/text that referenced this issue Oct 16, 2021
@AlexanderYastrebov
x/text: translate messages formatted via non-printf methods
ab3305e 
Fixes golang/go#41781
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Oct 16, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/356314 mentions this issue: x/text: translate messages formatted via non-printf methods

@mpvl
Copy link
Contributor

mpvl commented Nov 2, 2021

Translations are only done for format strings or substitutions in %m. So this is intentional.

In my opinion, also translating strings for Print variants is undesirable. But even if it is, this would now be a backwards incompatible change.

To print without a message, one can use p.Printf("%m", str).

@gabyhelp gabyhelp mentioned this issue Oct 2, 2024
Closed
@SamWhited
Copy link
Member

SamWhited commented Oct 2, 2024 •
edited
Loading

Just ran into this as well; it is unclear to me why this is undesirable, but to be clear this also happens for printer.Print calls, eg. if I write:

fmt.Print(printer.Sprint("Foo"))

The message "Foo" will not be extracted. But I very clearly meant for it to be translated.

EDIT: also the suggested workaround results in Key "%m" matches conflicting messages"

@SamWhited
Copy link
Member

I just realized that the reason it's likely undesirable is that we're not sure if the string is an id or a message if we're not using Printf. That's understandable, but given that the workaround doesn't seem to work (and just using Sprintf("Foo") triggers lots of linter false positives) I'm still not sure what to do about it.

@seankhliao
Copy link
Member

closing as working as intended.

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

x/text: translate messages formatted via non-printf methods AlexanderYastrebov/text
6 participants
@kalbasit @SamWhited @dmitshur @mpvl @gopherbot @seankhliao