Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: move initialization to the snapshot #41764

Closed
stamblerre opened this issue Oct 2, 2020 · 2 comments
Closed

x/tools/gopls: move initialization to the snapshot #41764

stamblerre opened this issue Oct 2, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.3

Comments

@stamblerre
Copy link
Contributor

The current scheme of reinitialization has pushed a lot of logic into the snapshot. Refactor so that initialization is based on the snapshot's status, not the view's.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 2, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 2, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Oct 2, 2020
@stamblerre stamblerre self-assigned this Oct 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/266343 mentions this issue: internal/lsp: move initialization entirely onto the snapshot

@gopherbot
Copy link

Change https://golang.org/cl/266700 mentions this issue: internal/lsp: move initialization entirely into the snapshot

gopherbot pushed a commit to golang/tools that referenced this issue Nov 2, 2020
@stamblerre
internal/lsp: move initialization entirely into the snapshot
51cde52 
The majority of the initialization logic is already based on the
snapshot, not the view, so it makes sense to move it there. The
initialization status of the snapshot is copied and invalidated in
clone.

Fixes golang/go#41764

Change-Id: I93234b394318964e7af4696e5ebd465088a05728
Reviewed-on: https://go-review.googlesource.com/c/tools/+/266700
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@golang golang locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.3
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot