Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: 'makeToplevelFunction': not lowered: v109, StructMake1 STRUCT UNSAFEPTR #41736

Closed
OneOfOne opened this issue Oct 1, 2020 · 7 comments
Closed

cmd/compile: internal compiler error: 'makeToplevelFunction': not lowered: v109, StructMake1 STRUCT UNSAFEPTR #41736

OneOfOne opened this issue Oct 1, 2020 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.16

Comments

@OneOfOne
Copy link
Contributor

OneOfOne commented Oct 1, 2020 

┏━ oneofone@voyager ❰~❱ 
┗━● go get -u github.com/go-delve/delve/...
go: found github.com/go-delve/delve/... in github.com/go-delve/delve v1.5.0
go: github.com/mattn/go-isatty upgrade => v0.0.12
go: github.com/peterh/liner upgrade => v1.2.0
go: github.com/spf13/cobra upgrade => v1.0.0
go: github.com/spf13/pflag upgrade => v1.0.5
go: github.com/sirupsen/logrus upgrade => v1.7.0
go: golang.org/x/arch upgrade => v0.0.0-20200826200359-b19915210f00
go: golang.org/x/sys upgrade => v0.0.0-20200930185726-fdedc70b468f
go: github.com/mattn/go-colorable upgrade => v0.1.7
go: github.com/google/go-dap upgrade => v0.3.0
go: github.com/konsorten/go-windows-terminal-sequences upgrade => v1.0.3
go: go.starlark.net upgrade => v0.0.0-20200929122913-88a10930eb75
go: gopkg.in/yaml.v2 upgrade => v2.3.0
go: github.com/mattn/go-runewidth upgrade => v0.0.9
# go.starlark.net/starlark
code/go/pkg/mod/go.starlark.net@v0.0.0-20200929122913-88a10930eb75/starlark/eval.go:463:14: internal compiler error: 'makeToplevelFunction': not lowered: v109, StructMake1 STRUCT UNSAFEPTR

goroutine 81 [running]:
runtime/debug.Stack(0xd6ef00, 0xc00000e018, 0x0)
	/usr/src/go/src/runtime/debug/stack.go:24 +0x9f
cmd/compile/internal/gc.Fatalf(0xc0006ede80, 0x8, 0xc0024f1980, 0x2, 0x2)
	/usr/src/go/src/cmd/compile/internal/gc/subr.go:199 +0x1b0
cmd/compile/internal/gc.(*ssafn).Fatalf(0xc000480a20, 0x1cf0e100000003, 0xc53802, 0x2, 0xc00188b3f0, 0x1, 0x1)
	/usr/src/go/src/cmd/compile/internal/gc/ssa.go:6987 +0x1a5
cmd/compile/internal/ssa.(*Func).Fatalf(...)
	/usr/src/go/src/cmd/compile/internal/ssa/func.go:652
cmd/compile/internal/ssa.checkLower(0xc00230cf20)
	/usr/src/go/src/cmd/compile/internal/ssa/lower.go:36 +0x41a
cmd/compile/internal/ssa.Compile(0xc00230cf20)
	/usr/src/go/src/cmd/compile/internal/ssa/compile.go:93 +0x9cd
cmd/compile/internal/gc.buildssa(0xc00013f340, 0x1, 0x0)
	/usr/src/go/src/cmd/compile/internal/gc/ssa.go:464 +0xd5a
cmd/compile/internal/gc.compileSSA(0xc00013f340, 0x1)
	/usr/src/go/src/cmd/compile/internal/gc/pgen.go:319 +0x5d
cmd/compile/internal/gc.compileFunctions.func2(0xc00194ac00, 0xc00092f6f0, 0x1)
	/usr/src/go/src/cmd/compile/internal/gc/pgen.go:384 +0x4d
created by cmd/compile/internal/gc.compileFunctions
	/usr/src/go/src/cmd/compile/internal/gc/pgen.go:382 +0x129


┏━ oneofone@voyager ❰~❱
┗━● go version
go version devel +5756b35601 2020-10-01 19:13:03 +0000 linux/amd64
@cherrymui
Copy link
Member

@dr2chase probably related to call lowering.

@dr2chase
Copy link
Contributor

dr2chase commented Oct 1, 2020

Totally related to call lowering.
Give me a few minutes....

@dr2chase
Copy link
Contributor

dr2chase commented Oct 1, 2020

PS @cherrymui can you have a look at https://go-review.googlesource.com/c/go/+/252338/6 ?
I made the requested changes in the latest patch set, it might be helpful in a case like this (if the problematic file happens to be vendored or in a module etc).

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 1, 2020
@andybons andybons added this to the Go1.16 milestone Oct 1, 2020
@cherrymui
Copy link
Member

Done.

@gopherbot
Copy link

Change https://golang.org/cl/258897 mentions this issue: cmd/compile: activate revert switch for late call expansion regression

@dr2chase
Copy link
Contributor

dr2chase commented Oct 1, 2020

That CL there needs a review, will keep the lights on for now. Thanks to @andybons for "big scary features need revert switches" (this is the same switch I use for binary search dev testing, so I know it works).

gopherbot pushed a commit that referenced this issue Oct 1, 2020
@dr2chase
cmd/compile: activate revert switch for late call expansion regression
c78c79f 
Not a fix, but things will work while I fix it.
Credit @andybons "for we revert switches for scary stuff".

Updates #41736

Change-Id: I55f90860eae919765aac4f6d9f108a54139027e1
Reviewed-on: https://go-review.googlesource.com/c/go/+/258897
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/259203 mentions this issue: cmd/compile: correct leaf type when "selecting" singleton register-sized struct

@golang golang locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
5 participants
@andybons @OneOfOne @dr2chase @gopherbot @cherrymui