Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/cache: compilation hangs with no output #41723

Closed
kevinburke opened this issue Oct 1, 2020 · 3 comments
Closed

cmd/go/internal/cache: compilation hangs with no output #41723

kevinburke opened this issue Oct 1, 2020 · 3 comments

Comments

@kevinburke
Copy link
Contributor

kevinburke commented Oct 1, 2020

I tried making a change to cmd/go/internal/cache to replace uses of fmt.Sprintf("%02x", i) with hex.EncodeToString. You can view the change here: https://go-review.googlesource.com/c/go/+/258039

The change didn't work, which is fine. However, instead of giving me an error message or explaining what went wrong, run.bash and all.bash just hung for over an hour with no output on the Building Go toolchain2 using go_bootstrap and Go toolchain1 line, which you can see here as of Wednesday at 5:30pm Pacific. https://farmer.golang.org/try?commit=f4ae3966

In fact, most of the Trybot builders appear to be stuck for multiple hours on that step, which isn't great since there appears to be no way to cancel a Trybot build.

I would expect compilation to either succeed or fail with an error, or time out with an error, instead of hanging indefinitely. I still don't know what's wrong with the CL.

@ALTree
Copy link
Member

ALTree commented Oct 1, 2020

there appears to be no way to cancel a Trybot build.

If you upload a new patch-set (change something in the code, anything), the trybots should cancel themselves. Does this work?

@kevinburke
Copy link
Contributor Author

kevinburke commented Oct 1, 2020 via email

@mvdan
Copy link
Member

mvdan commented Oct 1, 2020

I assume we can close this now; there wasn't a hang, the change simply made the Go tool loop forever.

@mvdan mvdan closed this as completed Oct 1, 2020
@golang golang locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants