Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add unit tests for snapshot.clone #41719

Closed
stamblerre opened this issue Sep 30, 2020 · 2 comments
Closed

x/tools/gopls: add unit tests for snapshot.clone #41719

stamblerre opened this issue Sep 30, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
gopls on-deck

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Sep 30, 2020 •
edited

It could also probably benefit from being refactored -- it is getting very long and complicated.

See https://golang.org/cl/258121.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Sep 30, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 30, 2020
@stamblerre stamblerre self-assigned this Oct 7, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Non-critical to Testing in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre added the Testing An issue that has been verified to require only test changes, not just a test failure. label Nov 10, 2020
@findleyr
Copy link
Contributor

findleyr commented Nov 11, 2020 •
edited

In https://golang.org/cl/261237, I factored out some of the cloning logic into cache/workspace.go, which has unit tests. We could probably carve it up a bit more though.

@stamblerre stamblerre removed this from Testing in vscode-go: gopls by default Dec 15, 2020
@stamblerre stamblerre added this to Documentation in vscode-go: gopls by default Dec 16, 2020
@stamblerre stamblerre moved this from Documentation to Testing in vscode-go: gopls by default Dec 16, 2020
@stamblerre stamblerre removed this from Testing in vscode-go: gopls by default Jan 14, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
@stamblerre stamblerre removed their assignment Apr 16, 2021
@findleyr
Copy link
Contributor

This is unfeasible without a refactoring, so let's not keep this issue around.

gopls on-deck automation moved this from To Do to Done Jun 28, 2021
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Jun 28, 2021
@golang golang locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr