Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: reset master to remove accidental merge CL #41718

Closed
dmitshur opened this issue Sep 30, 2020 · 4 comments
Closed

all: reset master to remove accidental merge CL #41718

dmitshur opened this issue Sep 30, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 30, 2020 •
edited

The merge CL 258525 was accidentally merged into the master branch, rather than the intended branch.

I'll rewrite history to revert master to the parent commit, which is 846dce9d05f19a1f53465e62a304dea21b99f910.
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Sep 30, 2020
@dmitshur dmitshur self-assigned this Sep 30, 2020
@dmitshur dmitshur pinned this issue Sep 30, 2020
@dmitshur
Copy link
Contributor Author

This is now done.

If you've submitted a CL to master branch recently and it's not there now, please re-send it.

@dmitshur dmitshur mentioned this issue Sep 30, 2020
Open
@dmitshur dmitshur unpinned this issue Oct 1, 2020
@gopherbot
Copy link

Change https://golang.org/cl/258677 mentions this issue: syscall: use correct cmsg alignment for netbsd/arm64

@networkimprov
Copy link

What was the HEAD right before history was rewritten?

gopherbot pushed a commit that referenced this issue Oct 1, 2020
@tklauser
syscall: use correct cmsg alignment for netbsd/arm64
069aef4 
netbsd/arm64 requires 128-bit alignment for cmsgs.

Re-submit of CL 258437 which was dropped due to #41718.

Change-Id: I898043d79f513bebe1a5eb931e7ebd8e291a5aec
Reviewed-on: https://go-review.googlesource.com/c/go/+/258677
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Benny Siegert <bsiegert@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
@dmitshur
Copy link
Contributor Author

dmitshur commented Oct 1, 2020

It was previously 48e542e58588bc75faacd63439f40e57db80b2f1 at the time of the force push.

From looking, the only CL I see dropped was CL 258437. It was re-sent as CL 258677.

@golang golang locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@networkimprov @dmitshur @gopherbot