Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/test, x/tools/internal/lsp: inscrutable test output on failure #41717

Closed
bcmills opened this issue Sep 30, 2020 · 2 comments
Closed

x/tools/gopls/test, x/tools/internal/lsp: inscrutable test output on failure #41717

bcmills opened this issue Sep 30, 2020 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 30, 2020

What version of Go are you using (go version)?

https://golang.org/cl/258298

What did you do?

Run TryBots for x/tools.

What did you expect to see?

All tests passing, or a test log with a clear indication of what actually went wrong (per http://golang.org/wiki/CodeReviewComments#useful-test-failures).

What did you see instead?

https://storage.googleapis.com/go-build-log/624a58dc/linux-amd64_445ec507.log

which contains what appears to me as a wall of text followed by an otherwise-disconnected diff in an expected output count:

--- FAIL: TestCommandLine (31.97s)
    --- FAIL: TestCommandLine/Modules (16.61s)
        tests.go:884: test summary does not match:
            --- want
            +++ got
            @@ -7,7 +7,7 @@
             FuzzyCompletionsCount = 8
             RankedCompletionsCount = 157
             CaseSensitiveCompletionsCount = 4
            -DiagnosticsCount = 44
            +DiagnosticsCount = 43
             FoldingRangesCount = 2
             FormatCount = 6
             ImportCount = 8
FAIL
FAIL	golang.org/x/tools/gopls/test	32.066s

From that output, I have no idea which of the 44(!) expected diagnostics from the test was missing, or which line or source file was intended to produce that missing diagnostic.
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Sep 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 30, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Sep 30, 2020

CC @stamblerre @heschik @ianthehat

@stamblerre stamblerre removed this from the Unreleased milestone Oct 1, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@findleyr
Copy link
Contributor

findleyr commented Sep 7, 2023

Closing as dupe of https://go.dev/issue/54845.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@bcmills @stamblerre @gopherbot @findleyr