Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/internal/releasetargets: distribute official binaries for netbsd/arm64 #41706

Closed
bsiegert opened this issue Sep 30, 2020 · 11 comments
Closed
Labels
arch-arm64 Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD
Milestone

Comments

@bsiegert
Copy link
Contributor

Now that the netbsd/arm64 port has stabilized somewhat, I would like to ask for it to be part of the release binaries. That is, the 1.16 release should contain a .tar.gz with binaries for netbsd/arm64.

This would be useful for bootstrapping: In the OS packages (pkgsrc), we need a Go version to build Go itself. So far, we have been using a patched 1.14.2 that was built on a NetBSD Foundation machine. An official binary would be much simpler.

@andybons
Copy link
Member

andybons commented Oct 1, 2020

/cc @golang/osp-team

@andybons andybons added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 1, 2020
@andybons andybons added this to the Go1.16 milestone Oct 1, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Oct 1, 2020

To make a release, a builder is required (it's used in a releaselet mode). The netbsd-arm64-bsiegert builder is available for netbsd/arm64. Is that the builder you suggest we use @bsiegert?

@dmitshur dmitshur added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 1, 2020
@bsiegert
Copy link
Contributor Author

bsiegert commented Oct 2, 2020

Yes. @cagedmantis was going to work on a non-reverse builder, until that's landed, mine should be good.

@dmitshur dmitshur removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 2, 2020
@cagedmantis
Copy link
Contributor

@bsiegert the non-reverse builder is still planned.

@bsiegert
Copy link
Contributor Author

bsiegert commented Oct 5, 2020 via email

@dmitshur dmitshur added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 12, 2020
@dmitshur dmitshur changed the title release: distribute official binaries for netbsd/arm64 for 1.16 x/build/cmd/releasebot: distribute official binaries for netbsd/arm64 for 1.16 Oct 12, 2020
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) FeatureRequest labels Oct 22, 2020
@odeke-em
Copy link
Member

odeke-em commented Feb 9, 2021

We haven't yet gotten to this for Go1.16, but it shouldn't block the release. Punting to Go1.17; thank you everyone for the discussion and for the patience.

@odeke-em odeke-em modified the milestones: Go1.16, Go1.17 Feb 9, 2021
@dmitshur dmitshur changed the title x/build/cmd/releasebot: distribute official binaries for netbsd/arm64 for 1.16 x/build/cmd/releasebot: distribute official binaries for netbsd/arm64 Apr 28, 2021
@mknyszek
Copy link
Contributor

Has any progress been made on this? Otherwise I'll punt it to backlog, since it's already been punted for one release.

@dmitshur
Copy link
Contributor

@mknyszek Thanks for checking in. This issue is currently in NeedsDecision state, and I added it to a list of issues for the release team to review for 1.17 during a meeting tomorrow, so I expect we'll update it soon.

@bsiegert
Copy link
Contributor Author

If it helps: having official binaries for netbsd/arm64 would be good for the NetBSD packages. We have https://pkgsrc.se/lang/go-bin with official binaries for bootstrapping, but we had to use a NetBSD Foundation build for arm64.

@dmitshur
Copy link
Contributor

We discussed this on the release team and decided that we cannot add this binary release target in time for Go 1.17 unfortunately. Each additional release target carries some overhead and risk for the release process, and given our current state, we don't have the room to take this on before completing some work to reduce that overhead and risk. We would like to be able to do this at some point, but we won't be able to get to it to 1.17 because there isn't time given the amount of work still needed to done to release 1.17.

I'll move this to Backlog for now so we can come back to this when there is more time.

@bsiegert Thanks for additional context in the comment above, it is helpful for us to make a more informed decision about which ports we want to prioritize adding binary releases for. We've discussed that we also want to make it a prerequisite to have a more detailed cost/benefit analysis as part of prioritizing potential ports to add binaries for. When we're ready to make progress here, we may try to find out even more information.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels May 27, 2021
@dmitshur dmitshur modified the milestones: Go1.17, Backlog May 27, 2021
@dmitshur dmitshur changed the title x/build/cmd/releasebot: distribute official binaries for netbsd/arm64 x/build/internal/releasetargets: distribute official binaries for netbsd/arm64 Aug 3, 2022
@dmitshur dmitshur removed this from the Backlog milestone Aug 3, 2022
@dmitshur dmitshur added this to the Unreleased milestone Aug 3, 2022
@dmitshur
Copy link
Contributor

This is done as part of #53862.

Binary releases for the netbsd/arm64 port will be available starting with Go 1.21.
For example, see go1.21rc2.netbsd-arm64.tar.gz at https://go.dev/dl/#go1.21rc2.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsFix The path to resolution is known, but the work has not been done. OS-NetBSD
Projects
None yet
Development

No branches or pull requests

6 participants