Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: don't use retracted versions as pseudo-version base versions #41700

Closed
jayconrod opened this issue Sep 29, 2020 · 1 comment
Closed

cmd/go: don't use retracted versions as pseudo-version base versions #41700

jayconrod opened this issue Sep 29, 2020 · 1 comment
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.16

Comments

@jayconrod
Copy link
Contributor

What version of Go are you using (go version)?

1.16 tip (in development)

Does this issue reproduce with the latest release?

No, just tip.

What operating system and processor architecture are you using (go env)?

n/a

What did you do?

Suppose a module example.com/m tags v1.0.0, then tags v1.0.1 which retracts (#24031) both v1.0.0 and v1.0.1. Both tags refer to commits on the default branch. No other releases are tagged.

A user runs go get -d example.com/m@latest.

What did you expect to see?

The user should get a requirement on a pseudo-version based on v0.0.0, as they would if no versions are tagged.

What did you see instead?

The user gets a requirement on a pseudo-version based on v1.0.2.

Note that a pseudo-version based on v1.0.2 should still be valid; retraction shouldn't invalidate existing pseudo-versions.
@jayconrod jayconrod added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker modules labels Sep 29, 2020
@jayconrod jayconrod added this to the Go1.16 milestone Sep 29, 2020
@jayconrod jayconrod self-assigned this Sep 29, 2020
@dmitshur dmitshur added the GoCommand cmd/go label Oct 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/261079 mentions this issue: cmd/go: ignore retracted versions when converting revisions to versions

@hyangah hyangah mentioned this issue Nov 17, 2020
Closed
@golang golang locked and limited conversation to collaborators Oct 9, 2021
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
3 participants
@jayconrod @dmitshur @gopherbot