Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: show more than 10 results per page #41594

Closed
seankhliao opened this issue Sep 23, 2020 · 3 comments
Closed

x/pkgsite: show more than 10 results per page #41594

seankhliao opened this issue Sep 23, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/2021

Comments

@seankhliao
Copy link
Member

What is the URL of the page with the issue?

The search results page, ex:
https://pkg.go.dev/search?q=port+scan

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36

Screenshot

skip

What did you do?

Perform a search

What did you expect to see?

Option to (permanently?) show more than 10 results per page

What did you see instead?

results fixed at 10 per page

This is more of an issue for when there aren't well established/overwhelmingly popular libraries, or when the search is for something generic, where browsing through a longer page results would make the discovery process easier.
@gopherbot gopherbot added this to the Unreleased milestone Sep 23, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/search Sep 23, 2020
@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 23, 2020
@MistaTwista
Copy link

MistaTwista commented Oct 4, 2020 •
edited

There is a limit query param, to do what you need, currently its max value is 100, example (in code it's there internal/frontend/search.go:123)

I can implement this feature at frontend, I think it should be somewhere here content/static/html/pages/search.tmpl or there content/static/html/helpers/_pagination.tmpl

"Because we are currently working on design updates to pkg.go.dev, we will not be accepting any contributions for issues with a UX label." looks like this issue will take UX label...

@jba
Copy link
Contributor

jba commented Jul 21, 2021

See #47315

@julieqiu julieqiu modified the milestones: pkgsite/search, pkgsite/2021 Sep 13, 2021
@hyangah
Copy link
Contributor

hyangah commented May 20, 2022

Currently pkgsite shows 25 in the first page and provides an option to see more results (with limit parameter 100) at the bottom of the page.

Closing.

@hyangah hyangah closed this as completed May 20, 2022
@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label May 20, 2022
@golang golang locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/2021
Development

No branches or pull requests
6 participants
@MistaTwista @hyangah @julieqiu @gopherbot @seankhliao @jba