Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: Incorrect tar instructions for Linux download #41528

Closed
jgeiger-trane opened this issue Sep 21, 2020 · 7 comments
Closed

x/website: Incorrect tar instructions for Linux download #41528

jgeiger-trane opened this issue Sep 21, 2020 · 7 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@jgeiger-trane
Copy link

jgeiger-trane commented Sep 21, 2020 •
edited

It seems that the code to generate the CLI for the file that was downloaded is wrong and using a possibly hard coded version number.

When a user downloads the file, the instructions should return the instructions to install/unpack the file.

What did you do?

Downloaded Go 1.15.2

https://golang.org/doc/install?download=go1.15.2.linux-amd64.tar.gz

What did you expect to see?

tar -C /usr/local -xzf go1.15.2.linux-amd64.tar.gz

What did you see instead?

tar -C /usr/local -xzf go1.14.3.linux-amd64.tar.gz

image
@gopherbot gopherbot added this to the Unreleased milestone Sep 21, 2020
@AlexRouSg

This comment has been minimized.

Sign in to view
@ipriver
Copy link
Contributor

ipriver commented Sep 21, 2020 •
edited

I'm not sure how CI/CD works for different regions for the website, but the next day my fix got approved-merged it had been deployed and I've seen it working.
Currently, everything is ok for me in chrome/firefox/safari. Just in case, have you tried clearing the cache in your browser?

@ipriver
Copy link
Contributor

ipriver commented Sep 21, 2020

NVM, looks like your issue is valid and it's not because of the deployment.
Previously I used Win/macOS for the development and missed it. Now I was able to reproduce it on my Linux VM and it looks like the script is not executed when the page loads the Linux tab.
Gonna work on that, thanks @jgeiger-trane

@ipriver ipriver mentioned this issue Sep 21, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/256318 mentions this issue: doc/install: fixed how JS defines browser OS

@ipriver
Copy link
Contributor

ipriver commented Sep 21, 2020

Created an issue #41537 which is the reason why Linux instructions aren't updating.
And created a PR that should solve it.

@cagedmantis
Copy link
Contributor

/cc @dmitshur @andybons

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 22, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 22, 2020
@dmitshur
Copy link
Contributor

Thanks for looking into this @ipriver. The underlying problem is a problem in the OS detection code.

Let's close this as duplicate of #41232, and use #41537 to track this issue.

gopherbot pushed a commit to golang/website that referenced this issue Oct 8, 2020
@ipriver @dmitshur
doc/install: fixed how JS defines browser OS
4c40783 
Updated "detectOS" function to use "userAgent" instead of "appVersion".
It has more info and using that it can be correctly detected that the
user uses Firefox on Linux. Users who want to be incognito can modify
these values in their browsers, so there is no workaround for such rare
cases. Added "else if" statements to prevent overwriting the variable.
Also, added a check that prevents to use "click" on "null" elements (in
case if OS haven't been detected or an element doesn't exist in DOM).

Fixes golang/go#41537
Fixes golang/go#41528

Change-Id: Iab94801008eddc17c039d49c19c98bef7641afeb
GitHub-Last-Rev: 6b891e9
GitHub-Pull-Request: #17
Reviewed-on: https://go-review.googlesource.com/c/website/+/256318
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Steve Traut <straut@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Sep 22, 2021
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
doc/install: fixed how JS defines browser OS
1174ef4 
Updated "detectOS" function to use "userAgent" instead of "appVersion".
It has more info and using that it can be correctly detected that the
user uses Firefox on Linux. Users who want to be incognito can modify
these values in their browsers, so there is no workaround for such rare
cases. Added "else if" statements to prevent overwriting the variable.
Also, added a check that prevents to use "click" on "null" elements (in
case if OS haven't been detected or an element doesn't exist in DOM).

Fixes golang/go#41537
Fixes golang/go#41528

Change-Id: Iab94801008eddc17c039d49c19c98bef7641afeb
GitHub-Last-Rev: 6b891e9757ec61cd8107f53669f8ed1c0b807294
GitHub-Pull-Request: golang/website#17
Reviewed-on: https://go-review.googlesource.com/c/website/+/256318
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Steve Traut <straut@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

doc/install: fixed how JS defines browser OS
6 participants
@cagedmantis @dmitshur @AlexRouSg @gopherbot @ipriver @jgeiger-trane