Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: deep completion misranked #41489

Closed
muirdm opened this issue Sep 18, 2020 · 4 comments
Closed

x/tools/gopls: deep completion misranked #41489

muirdm opened this issue Sep 18, 2020 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.1

Comments

@muirdm
Copy link

muirdm commented Sep 18, 2020

See below screenshot. I expect &bytes.Buffer{} to be the first candidate, but for some reason packages are winning.

Screen Shot 2020-09-18 at 2 29 38 PM
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 18, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 18, 2020
@stamblerre
Copy link
Contributor

@muirdm: This is with gopls at master (and the deep completion CL), I assume?

/cc @heschik @dandua98

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.1 Sep 18, 2020
@muirdm
Copy link
Author

muirdm commented Sep 18, 2020

This is with gopls at master (and the deep completion CL), I assume?

Yes, master at e94ab72. I've been noticing it for a while, though.

@dandua98
Copy link

dandua98 commented Sep 18, 2020 •
edited
Loading

Was not able to reproduce on master, strange. Seem to be ordered as expected for me. The order is actually reversed for you. Is this with vscode-go? I'm wondering if it's the client side implementation.

image

@muirdm
Copy link
Author

muirdm commented Sep 19, 2020

It seems my editor has suddenly started changing the order of candidates for some reason 😠 . Sorry!

@muirdm muirdm closed this as completed Sep 19, 2020
@golang golang locked and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.1
Development

No branches or pull requests
4 participants
@stamblerre @gopherbot @muirdm @dandua98