Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/addr2line: TestAddr2Line fails with double / in $GOROOT_FINAL [1.15 backport] #41453

Closed
gopherbot opened this issue Sep 17, 2020 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Sep 17, 2020

@bcmills requested issue #41447 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to 1.15. See rationale in #41447 (comment).

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 17, 2020
@gopherbot gopherbot added this to the Go1.14.10 milestone Sep 17, 2020
@bcmills bcmills changed the title cmd/addr2line: TestAddr2Line fails with double / in $GOROOT_FINAL [1.14 backport] cmd/addr2line: TestAddr2Line fails with double / in $GOROOT_FINAL [1.15 backport] Sep 17, 2020
@bcmills bcmills modified the milestones: Go1.14.10, Go1.15.3 Sep 17, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/255658 mentions this issue: [release-branch.go1.15] cmd/addr2line: don't assume that GOROOT_FINAL is clean

@dmitshur
Copy link
Contributor

dmitshur commented Oct 6, 2020

Approving as this is a regression in Go 1.15 which can cause the test to fail erroneously in certain constrained environments, and it is a test-only fix. Only 1.15 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. and removed CherryPickCandidate Used during the release process for point releases labels Oct 6, 2020
@gopherbot
Copy link
Author

Closed by merging 400c68a to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Oct 6, 2020
… is clean

Updates #41447
Fixes #41453

Change-Id: I4460c1c7962d02c41622a5ea1a3c4bc3714a1873
Reviewed-on: https://go-review.googlesource.com/c/go/+/255477
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 6796a7f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/255658
@navytux
Copy link
Contributor

navytux commented Oct 7, 2020

Thanks

claucece pushed a commit to claucece/go that referenced this issue Oct 22, 2020
… is clean

Updates golang#41447
Fixes golang#41453

Change-Id: I4460c1c7962d02c41622a5ea1a3c4bc3714a1873
Reviewed-on: https://go-review.googlesource.com/c/go/+/255477
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 6796a7f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/255658
@golang golang locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants