Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: executeCommand failures should be clearly shown to the user #41413

Closed
stamblerre opened this issue Sep 16, 2020 · 1 comment
Closed

x/tools/gopls: executeCommand failures should be clearly shown to the user #41413

stamblerre opened this issue Sep 16, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.1

Comments

@stamblerre
Copy link
Contributor

I just ran extract to function and it failed silently. Any command failure should be shown to the user via a ShowMessage.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Sep 16, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 16, 2020
@findleyr findleyr self-assigned this Sep 16, 2020
@gopherbot
Copy link

Change https://golang.org/cl/255128 mentions this issue: internal/lsp: always show errors from running commands

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.1 Sep 17, 2020
@golang golang locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.1
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr