Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: <div role="tablist"> on Details Page inappropriately nested in Nav region #41381

Closed
kmstorer opened this issue Sep 14, 2020 · 1 comment
Closed

x/pkgsite: <div role="tablist"> on Details Page inappropriately nested in Nav region #41381

kmstorer opened this issue Sep 14, 2020 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@kmstorer
Copy link

What version of Go are you using (go version)?

NA

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

Tablist on details page is nested within a nav region. Screen reader users expect to see nav regions only at the top of each page, and this is disorienting.

What did you expect to see?

Proposal: Tablist should be removed and all content consolidated to one page.

What did you see instead?
@toothrot toothrot changed the title <div role="tablist"> on Details Page inappropriately nested in Nav region x/pkgsite: <div role="tablist"> on Details Page inappropriately nested in Nav region Sep 15, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 15, 2020
@toothrot toothrot added website NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 15, 2020
@julieqiu julieqiu added pkgsite and removed website labels Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
@jba jba modified the milestones: Unreleased, pkgsite/frontend Sep 19, 2020
@jamalc
Copy link

jamalc commented May 11, 2021

Obsolete. We're no longer using the tablist role on pkgsite.

@jamalc jamalc closed this as completed May 11, 2021
@golang golang locked and limited conversation to collaborators May 11, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
7 participants
@toothrot @hyangah @julieqiu @gopherbot @jamalc @jba @kmstorer