gollvm: cmd/go: httpguts, hpack, idna are not using a known version control system #41368

advancedwebdeveloper · 2020-09-13T18:48:07Z

What version of Go are you using (`go version`)?

$ go version
go version go1.15rc2 gollvm LLVM 12.0.0git linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/oceanfish81/.cache/go-build"
GOENV="/home/oceanfish81/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/oceanfish81/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/oceanfish81/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/tools"
GCCGO="/usr/local/bin/llvm-goc"
AR="ar"
CC="/usr/bin/clang"
CXX="/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build842983669=/tmp/go-build -gno-record-gcc-switches -funwind-tables"

What did you do?

I was trying to get StreamSets Data Collector Edge working.

$ go get -u github.com/streamsets/datacollector-edge

What did you expect to see?

At least - no warning or errors.

What did you see instead?

package golang.org/x/net/http/httpguts: directory "/usr/local/src/golang.org/x/net/http/httpguts" is not using a known version control system
package golang.org/x/net/http2/hpack: directory "/usr/local/src/golang.org/x/net/http2/hpack" is not using a known version control system
package golang.org/x/net/idna: directory "/usr/local/src/golang.org/x/net/idna" is not using a known version control system

@bradfitz, @FiloSottile , @alanbato, @mpvl - any suggestions?

Ivan

The text was updated successfully, but these errors were encountered:

alanbato · 2020-09-13T18:52:32Z

None at all, I don't even use go 🤔

Maybe you meant to tag someone else? 😅

ianlancetaylor · 2020-09-13T19:21:24Z

CC @thanm @cherrymui

Do you have any replace directives in your go.mod file?

advancedwebdeveloper · 2020-09-14T09:46:51Z

CC @thanm @cherrymui

Do you have any replace directives in your go.mod file?
@ianlancetaylor , which file are you referring here?

advancedwebdeveloper · 2020-09-14T11:28:21Z

https://github.com/streamsets/datacollector-edge project does not contain any go.mod file.

thanm · 2020-09-14T13:26:06Z

I took a look at this -- I can reproduce, but I don't have any insight into what's going wrong. I don't see any replace directives at least as far as I can tell.

jayconrod · 2020-09-14T14:45:05Z

I don't think this is related to modules. This error would be reported in GOPATH mode if a repository root path resolves to a directory in $GOPATH/src but that directory doesn't actually contain a repository subdirectory (like .git).

Does the directory $GOPATH/src/golang.org/x/net/.git exist? What about $GOPATH/src/golang.org/x/net/http/httpguts/.git?

thanm · 2020-09-14T15:05:46Z

Does the directory $GOPATH/src/golang.org/x/net/.git exist?

Yes, $GOPATH/src/golang.org/x/net/.git exists.

What about $GOPATH/src/golang.org/x/net/http/httpguts/.git?

No, that does not exist.

bcmills · 2020-09-14T18:26:56Z

Those three packages are vendored into the standard library:

go/src/vendor/modules.txt

Lines 14 to 17 in 86dbeef

    
           golang.org/x/net/http/httpguts 
        
           golang.org/x/net/http/httpproxy 
        
           golang.org/x/net/http2/hpack 
        
           golang.org/x/net/idna

So probably this has something to do with standard-library vendoring in GOPATH mode, but I'm not sure what.

bcmills · 2020-09-14T18:30:15Z

Yeah, that go env output indicates GOROOT="/usr/local", so the path /usr/local/src/golang.org/x/net/http/httpguts would be in GOROOT/src, but it's presumably not in GOROOT/src because the correct path there (in Go 1.15rc2) would be /usr/local/src/vendor/golang.org/x/net/http/httpguts.

advancedwebdeveloper · 2020-09-14T18:33:30Z

@bcmills , so what should be patched?

bcmills · 2020-09-14T18:37:14Z

@advancedwebdeveloper, that depends on what the root cause turns out to be. 😅

Could you run ls -d /usr/local/src/golang.org and ls -d /usr/local/src/vendor/golang.org and post the results?

advancedwebdeveloper · 2020-09-15T08:56:16Z

I don't think this is related to modules. This error would be reported in GOPATH mode if a repository root path resolves to a directory in $GOPATH/src but that directory doesn't actually contain a repository subdirectory (like .git).

Does the directory $GOPATH/src/golang.org/x/net/.git exist?

@jayconrod , $GOPATH is not defined (for some reason) - and that a "by default" state, since I have installed compiled "release" build of gollvm.
Better ask @thanm and @cherrymui , what is the problem with $GOPATH, during the installation process.

But a de-facto directory does exist:

~$ file $GOPATH/src/golang.org/x/net/.git
/src/golang.org/x/net/.git: cannot open `/src/golang.org/x/net/.git' (No such file or directory)
~$ file go/src/golang.org/x/net/.git
go/src/golang.org/x/net/.git: directory
~$ file go/src/golang.org/x/net/.git/
go/src/golang.org/x/net/.git/: directory
~$ ls go/src/golang.org/x/net/.git/
FETCH_HEAD HEAD ORIG_HEAD branches config description hooks index info logs objects packed-refs refs
$ cat go/src/golang.org/x/net/.git/HEAD
ref: refs/heads/master

What about $GOPATH/src/golang.org/x/net/http/httpguts/.git?

Well, in case of this file - neither de-facto nor relative path/fiel exists:

~$ file $GOPATH/src/golang.org/x/net/http/httpguts/.git
/src/golang.org/x/net/http/httpguts/.git: cannot open /src/golang.org/x/net/http/httpguts/.git' (No such file or directory) ~$ file go/src/golang.org/x/net/http/httpguts/.git go/src/golang.org/x/net/http/httpguts/.git: cannot open go/src/golang.org/x/net/http/httpguts/.git' (No such file or directory)
$ ls go/src/golang.org/x/net/http/httpguts/
guts.go httplex.go httplex_test.go
$ ls -a go/src/golang.org/x/net/http/httpguts/
. .. guts.go httplex.go httplex_test.go

Ivan

advancedwebdeveloper · 2020-09-15T08:58:56Z

Yeah, that go env output indicates GOROOT="/usr/local", so the path /usr/local/src/golang.org/x/net/http/httpguts would be in GOROOT/src, but it's presumably not in GOROOT/src because the correct path there (in Go 1.15rc2) would be /usr/local/src/vendor/golang.org/x/net/http/httpguts.

@bcmills ,
it is hirely undesirable to use system sub-folders - I would be glad to stick to my directories inside the home folder.
I can check by specifying $GOPATH (so it would point to "~/go") and report.
Ivan

advancedwebdeveloper · 2020-09-15T09:01:51Z

@advancedwebdeveloper, that depends on what the root cause turns out to be. 😅

Could you run ls -d /usr/local/src/golang.org and ls -d /usr/local/src/vendor/golang.org and post the results?

Surely I am able to do that:

$ ls -d /usr/local/src/golang.org
ls: cannot access '/usr/local/src/golang.org': No such file or directory

dir. does not exist

$ ls -d /usr/local/src/vendor/golang.org
ls: cannot access '/usr/local/src/vendor/golang.org': No such file or directory

same here.

Ivan

gopherbot · 2020-09-21T19:48:53Z

Change https://golang.org/cl/256319 mentions this issue: libgo: don't put golang.org packages in zstdpkglist.go

gopherbot · 2020-09-21T20:25:34Z

Change https://golang.org/cl/256362 mentions this issue: gollvm: don't add golang.org packges to zstdpkglist.go

This ensures that internal/goroot.IsStandardPackage does not treat golang.org packages as being in the standard library. For golang/go#41368 Fixes golang/go#41499 Change-Id: I58abc84c6c8544b3d7f513bda7a5e5a63d0a9937 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/256319 Trust: Ian Lance Taylor <iant@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Than McIntosh <thanm@google.com>

This ensures that internal/goroot.IsStandardPackage does not treat golang.org packages as being in the standard library. For golang/go#41368 Fixes golang/go#41499 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/256319

ianlancetaylor changed the title ~~[gollvm] httpguts, hpack, idna are not using a known version control system~~ gollvm: cmd/go: httpguts, hpack, idna are not using a known version control system Sep 13, 2020

ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 13, 2020

ianlancetaylor added this to the gollvm milestone Sep 13, 2020

bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Sep 15, 2020

zhsj mentioned this issue Sep 20, 2020

gccgo: no Go files in /usr/src/golang.org/x/net/http/httpguts #41499

Closed

joedian removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gollvm: cmd/go: httpguts, hpack, idna are not using a known version control system #41368

gollvm: cmd/go: httpguts, hpack, idna are not using a known version control system #41368

advancedwebdeveloper commented Sep 13, 2020 •

edited by bcmills

alanbato commented Sep 13, 2020

ianlancetaylor commented Sep 13, 2020

advancedwebdeveloper commented Sep 14, 2020

advancedwebdeveloper commented Sep 14, 2020

thanm commented Sep 14, 2020

jayconrod commented Sep 14, 2020

thanm commented Sep 14, 2020

bcmills commented Sep 14, 2020

bcmills commented Sep 14, 2020 •

edited

advancedwebdeveloper commented Sep 14, 2020

bcmills commented Sep 14, 2020

advancedwebdeveloper commented Sep 15, 2020

advancedwebdeveloper commented Sep 15, 2020 •

edited

advancedwebdeveloper commented Sep 15, 2020

gopherbot commented Sep 21, 2020

gopherbot commented Sep 21, 2020

gollvm: cmd/go: httpguts, hpack, idna are not using a known version control system #41368

gollvm: cmd/go: httpguts, hpack, idna are not using a known version control system #41368

Comments

advancedwebdeveloper commented Sep 13, 2020 • edited by bcmills

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

alanbato commented Sep 13, 2020

ianlancetaylor commented Sep 13, 2020

advancedwebdeveloper commented Sep 14, 2020

advancedwebdeveloper commented Sep 14, 2020

thanm commented Sep 14, 2020

jayconrod commented Sep 14, 2020

thanm commented Sep 14, 2020

bcmills commented Sep 14, 2020

bcmills commented Sep 14, 2020 • edited

advancedwebdeveloper commented Sep 14, 2020

bcmills commented Sep 14, 2020

advancedwebdeveloper commented Sep 15, 2020

advancedwebdeveloper commented Sep 15, 2020 • edited

advancedwebdeveloper commented Sep 15, 2020

gopherbot commented Sep 21, 2020

gopherbot commented Sep 21, 2020

advancedwebdeveloper commented Sep 13, 2020 •

edited by bcmills

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

bcmills commented Sep 14, 2020 •

edited

advancedwebdeveloper commented Sep 15, 2020 •

edited