Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: proposal: add link on Not Found page #41347

Closed
fgergo opened this issue Sep 11, 2020 · 5 comments
Closed

x/pkgsite: proposal: add link on Not Found page #41347

fgergo opened this issue Sep 11, 2020 · 5 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite
Milestone
pkgsite/unplanned

Comments

@fgergo
Copy link

fgergo commented Sep 11, 2020

https://pkg.go.dev/nosuchpackage returns "404 Not Found" as it should.
I'd propose to add a link below the error message, something like this:
Add a package to pkg.go.dev.

background: #41318
@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2020
@seankhliao
Copy link
Member

the functionality exists when you use a proper package path, ex: https://pkg.go.dev/github.com/nosuch/package

@fgergo
Copy link
Author

fgergo commented Sep 11, 2020

@seankhliao You probably misunderstood the proposal.
Please take a look again at the proposed link and maybe have a look at #41318 .

@seankhliao
Copy link
Member

This is what I see right now: a button with "Request " (you may have to use a not negatively cached url).
Does this not do what your proposal covers?
2020-09-12-002712

@fgergo
Copy link
Author

fgergo commented Sep 11, 2020 via email

@ALTree ALTree added FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Sep 12, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/255097 mentions this issue: content/static/html/pages: link to package-adding instructions on 404

@jba jba modified the milestones: Unreleased, pkgsite/unplanned Sep 15, 2020
@golang golang locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
6 participants
@ALTree @fgergo @julieqiu @gopherbot @seankhliao @jba