Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: broken debug pages #41343

Closed
findleyr opened this issue Sep 11, 2020 · 1 comment
Closed

x/tools/gopls: broken debug pages #41343

findleyr opened this issue Sep 11, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Projects
vscode-go: gopls by default

Comments

@findleyr
Copy link
Contributor

findleyr commented Sep 11, 2020 •
edited

Our debug pages were broken by https://golang.org/cl/245058. Sample error: template: :8:49: executing "body" at <.Identity>: can't evaluate field Identity in type source.Overlay.

Clearly these are not widely used as they have been broken for over a month without anyone noticing, but they can be very useful. We should fix them and add a regtest that all of our debug templates render.

cc @heschik @ianthehat @stamblerre
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 11, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Sep 11, 2020
@stamblerre stamblerre added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 17, 2020
@stamblerre stamblerre added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Nov 2, 2020
@findleyr findleyr moved this from Critical to Non-critical in vscode-go: gopls by default Nov 11, 2020
@gopherbot
Copy link

Change https://golang.org/cl/270099 mentions this issue: internal/lsp: get debug pages limping along again

@pjweinb pjweinb self-assigned this Nov 15, 2020
vscode-go: gopls by default automation moved this from Non-critical to Done Nov 16, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Nov 16, 2020
@golang golang locked and limited conversation to collaborators Nov 16, 2021
@rsc rsc unassigned pjweinb Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
vscode-go: gopls by default
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pjweinb @stamblerre @gopherbot @findleyr