Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: 'go mod download' should update go.sum with zip sums of modules in build list #41341

Closed
jayconrod opened this issue Sep 11, 2020 · 1 comment
Closed

cmd/go: 'go mod download' should update go.sum with zip sums of modules in build list #41341

jayconrod opened this issue Sep 11, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.16

Comments

@jayconrod
Copy link
Contributor

What version of Go are you using (go version)?

03a6860, 1.15.2, 1.14.9

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="http://[::]:6123/mod"
GOROOT="/opt/go/installed"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/update/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build873245282=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Run go mod download in a module without a go.sum file.

go mod download
grep '^rsc.io/quote v1.5.2 ' go.sum

-- go.mod --
module m

go 1.16

require rsc.io/quote v1.5.2

What did you expect to see?

The go.sum file should contain sums for both the go.mod files needed by MVS and the content of modules in the build list.

What did you see instead?

The go.sum file only contains sums for the go.mod files.
@jayconrod jayconrod added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 11, 2020
@jayconrod jayconrod added this to the Go1.16 milestone Sep 11, 2020
@jayconrod jayconrod self-assigned this Sep 11, 2020
@gopherbot
Copy link

Change https://golang.org/cl/254357 mentions this issue: cmd/go: make 'go mod download' update go.sum after downloads are complete

@golang golang locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot