New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: didChangeConfiguration ignores the new configuration #41311
Comments
Change https://golang.org/cl/254038 mentions this issue: |
@stamblerre Thanks for looking into this
so quickly! I applied the patch in the CL (patch
set 5), but that didn't solve
the issue. |
Thanks for testing it out! It's fine/probably easier to leave comments here. |
@stamblerre Ah, I see what's wrong
now. |
After receiving workspace/didChangeConfiguration some servers will request the full updated configuration from the client using workspace/configuration instead of reading the changed configuration section clients have sent them. So, support this capability and respond with a workspace configuration if there is one. See also: golang/go#41311.
Perfect--thanks for doing that! And definitely not noise - there was a |
Change https://golang.org/cl/254427 mentions this issue: |
…ngeConfiguration As we have modified the ways that we control which analyzers get executed for a given case, we have lost the behavior of enabling and disabling staticcheck smoothly. This CL splits out the staticcheck analyzers from the main group so that the "staticcheck" setting can override whether or not a given staticcheck analysis is enabled. Fixes golang/go#41311 Change-Id: I9c1695afe4a8f89cd0ee50a79e83b2f42a2c20cb Reviewed-on: https://go-review.googlesource.com/c/tools/+/254427 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
I was trying to enable
staticcheck
usinggopls
versionv0.5.0-pre1
andnatebosch/vim-lsc
, but couldn't. The plugin configuration was:I also used
-rpc.trace
and made sure thatgopls
actually receives the configuration with theworkspace/didChangeConfiguration
method. I inspected the code, and it seems like parameterchanged
of the server implementation is currently ignored:If I enable
stderr
logging and add alog.Printf("%#v", changed)
there, I can see, that the parameters are there:Is this a bug? Is there any additional information I should add?
The text was updated successfully, but these errors were encountered: