Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add log statement to indicate gopls is serving #41282

Open
stamblerre opened this issue Sep 9, 2020 · 3 comments
Open

x/tools/gopls: add log statement to indicate gopls is serving #41282

stamblerre opened this issue Sep 9, 2020 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Sep 9, 2020 •
edited

Running gopls on the command-line directly currently defaults to serve mode, which is unhelpful for users of the CLI and unintuitive. We should add a log message indicating that gopls is serving and how to get help text.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 9, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Sep 9, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Oct 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/260008 mentions this issue: goLanguageServer: use gopls serveinstead of the defaultgopls``

This was referenced Oct 7, 2020
Closed
Closed
Open
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Oct 8, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@stamblerre
Copy link
Contributor Author

@findleyr and @ianthehat have discussed that most language servers do default to serve, but we can improve the UX by adding a log statement. So I will repurpose this issue to add a log statement indicating that gopls is serving.

@mattn
Copy link
Member

mattn commented Nov 14, 2020

FYI, as far as that I have looked over 70 language servers in my project https://github.com/mattn/vim-lsp-settings, most language server does not provide serve command.

@stamblerre stamblerre changed the title x/tools/gopls: move away from defaulting to serve command x/tools/gopls: add log statement to indicate gopls is serving Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
3 participants
@mattn @stamblerre @gopherbot