Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: use of global logger in Server.register #41221

Closed
dangerousvasil opened this issue Sep 4, 2020 · 3 comments
Closed

net/rpc: use of global logger in Server.register #41221

dangerousvasil opened this issue Sep 4, 2020 · 3 comments
Labels
FrozenDueToAge

Comments

@dangerousvasil
Copy link

go/src/net/rpc/server.go

Line 267 in a15df60

log.Print(str)

@dangerousvasil
Copy link
Author

go/src/net/rpc/server.go

Line 244 in a15df60

log.Print(s)

@randall77
Copy link
Contributor

That's what its spec says it does:

// It returns an error if the receiver is not an exported type or has
// no suitable methods. It also logs the error using package log.

@mdlayher mdlayher changed the title debug log print in production! net/rpc: use of global logger in Server.register Sep 4, 2020
@mdlayher
Copy link
Member

mdlayher commented Sep 4, 2020

I'm not sure there's anything to be done here. The behavior is documented and net/rpc is frozen anyway, per https://golang.org/pkg/net/rpc/.

I'm going to close this out.

@mdlayher mdlayher closed this as completed Sep 4, 2020
@golang golang locked and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdlayher @randall77 @gopherbot @dangerousvasil