Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/fcgi: race detected during execution of TestResponseWriterSniffsContentType test [1.14 backport] #41192

Closed
gopherbot opened this issue Sep 2, 2020 · 3 comments
Closed

net/http/fcgi: race detected during execution of TestResponseWriterSniffsContentType test [1.14 backport] #41192

gopherbot opened this issue Sep 2, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14.9

Comments

@gopherbot
Copy link

@dmitshur requested issue #41167 to be considered for backport to the next 1.14 minor release.

Sounds good. Since the race isn't new and critical, the fix can be made available in Go 1.16 and we don't need to backport it. However, let's skip the new test so that the race builders continue to pass and provide full coverage on the release branches.

@gopherbot Please backport to both Go 1.15 and 1.14, but only the test fix.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 2, 2020
@gopherbot gopherbot mentioned this issue Sep 2, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.9 milestone Sep 2, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/252718 mentions this issue: [release-branch.go1.14] net/http/fgci: skip flaky test

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 2, 2020
@cagedmantis
Copy link
Contributor

Approved. This test exposes a pre-existing condition which which can block releases.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Sep 2, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 2, 2020
@gopherbot
Copy link
Author

Closed by merging 532db5d to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Sep 2, 2020
@FiloSottile @dmitshur
[release-branch.go1.14] net/http/fgci: skip flaky test
532db5d 
A test introduced in the security release is flaky due to a pre-existing
issue that does not qualify for backport itself.

Updates #41167
Fixes #41192

Change-Id: Ie6014e0796c1baee7b077881b5a799f9947fc9c2
Reviewed-on: https://go-review.googlesource.com/c/go/+/252718
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14.9
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot