Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa: relies on explicitly-unstable testing.MainStart #41186

Open
bcmills opened this issue Sep 2, 2020 · 1 comment
Open

x/tools/go/ssa: relies on explicitly-unstable testing.MainStart #41186

bcmills opened this issue Sep 2, 2020 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 2, 2020

https://build.golang.org/log/83ea7f332b5b9c7b09ee1f00d5ac8d6f947b29b0:

Entering directory `/workdir/gopath/src/golang.org/x/tools/go/pointer'
2020/09/02 14:32:24 internal error type-checking main$testmain: main$testmain.go:42:25: cannot use match (variable of type deps) as testing.testDeps value in argument to testing.MainStart: missing method SetPanicOnExit0
FAIL	golang.org/x/tools/go/pointer	4.716s

A short-term fix to add the missing method is trivial (in x/tools/go/ssa/testmain.go).

Longer term, x/tools/go/ssa should not be relying on the testing.testDeps interface or the testing.MainStart function. (testing.M and TestMain exist for a reason.)
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 2, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 2, 2020
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. and removed Tools This label describes issues relating to any tools in the x/tools repository. labels Sep 2, 2020
@bcmills bcmills modified the milestones: Unreleased, Backlog Sep 2, 2020
@gopherbot
Copy link

Change https://golang.org/cl/252677 mentions this issue: go/ssa: implement missing testing.testDeps SetPanicOnExit0 method

gopherbot pushed a commit to golang/tools that referenced this issue Sep 2, 2020
go/ssa: implement missing testing.testDeps SetPanicOnExit0 method
5b9ef24 
A new method was added to testing.testDeps in CL 250977, which causes
the implementation of that (unexported, explicitly-unstable) interface
in go/ssa to no longer satisfy the interface.

This is a quick, short-term fix. Longer term, the go/ssa package
should switch to the supported TestMain API.

Updates golang/go#41186

Change-Id: Ice110ef540e31a0a98085713346126ffeae64d5e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/252677
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot