Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include fix for #34437 in Go 1.14 release notes [1.15 backport] #41178

Closed
dmitshur opened this issue Sep 2, 2020 · 3 comments
Closed

doc: include fix for #34437 in Go 1.14 release notes [1.15 backport] #41178

dmitshur opened this issue Sep 2, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.15.2

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 2, 2020

@dmitshur requested issue #38801 to be considered for backport to the next 1.15 minor release.

This is a release note backport for 1.14, and it needs to be backported to 1.15 too now.
@dmitshur dmitshur added Documentation CherryPickCandidate Used during the release process for point releases labels Sep 2, 2020
@dmitshur dmitshur added this to the Go1.15.2 milestone Sep 2, 2020
@gopherbot
Copy link

Change https://golang.org/cl/252618 mentions this issue: [release-branch.go1.15] doc/go1.14: document json.Umarshal map key support of TextUnmarshaler

@cagedmantis
Copy link
Contributor

Approved as this is a documentation fix.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Sep 2, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 2, 2020
@gopherbot
Copy link

Closed by merging 60fdbce to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Sep 2, 2020
@ToastCheng @cagedmantis
[release-branch.go1.15] doc/go1.14: document json.Umarshal map key su…
60fdbce 
…pport of TextUnmarshaler

Document that json.Unmarshal supports map keys whose underlying
types implement encoding.TextUnmarshaler.

Updates #38801.
Fixes #41178.

Change-Id: Icb9414e9067517531ba0da910bd4a2bb3daace65
Reviewed-on: https://go-review.googlesource.com/c/go/+/237857
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 47b4509)
Reviewed-on: https://go-review.googlesource.com/c/go/+/252618
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
claucece pushed a commit to claucece/go that referenced this issue Oct 22, 2020
@ToastCheng @claucece
[release-branch.go1.15] doc/go1.14: document json.Umarshal map key su…
c81c7f9 
…pport of TextUnmarshaler

Document that json.Unmarshal supports map keys whose underlying
types implement encoding.TextUnmarshaler.

Updates golang#38801.
Fixes golang#41178.

Change-Id: Icb9414e9067517531ba0da910bd4a2bb3daace65
Reviewed-on: https://go-review.googlesource.com/c/go/+/237857
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 47b4509)
Reviewed-on: https://go-review.googlesource.com/c/go/+/252618
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.15.2
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot