Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/cmd/gorelease: TestRelease/errors/errors failing at tip #41146

Closed
jayconrod opened this issue Aug 31, 2020 · 1 comment
Closed

x/exp/cmd/gorelease: TestRelease/errors/errors failing at tip #41146

jayconrod opened this issue Aug 31, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@jayconrod
Copy link
Contributor

In golang.org/x/exp/cmd/gorelease, the test TestRelease/errors/errors is failing.

https://storage.googleapis.com/go-build-log/e01a226f/windows-amd64-2016_d27351a5.log

It looks like this was caused by CL 242083, which change the text of an error message in go/types. A few tests of gorelease are sensitive to the text of error messages, so they need to be updated.
@jayconrod jayconrod added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Aug 31, 2020
@jayconrod jayconrod self-assigned this Aug 31, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 31, 2020
@gopherbot
Copy link

Change https://golang.org/cl/251822 mentions this issue: cmd/gorelease: make TestRelease/errors/errors pass with new error message

@golang golang locked and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot