Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: "failed to fetch any source profiles" in TestTimePprof #41120

Closed
bcmills opened this issue Aug 29, 2020 · 5 comments
Closed

runtime: "failed to fetch any source profiles" in TestTimePprof #41120

bcmills opened this issue Aug 29, 2020 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.16

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2020

2020-08-28T21:23:32-a58a8d2/linux-amd64
2020-08-28T20:01:41-54e18f1/linux-amd64

There were two of these right in a row, and none with quite the same failure mode before today, so this looks like a possible 1.16 regression to me, possibly related to #41014.

CC @aclements @ianlancetaylor (via CL 97315)
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Aug 29, 2020
@bcmills bcmills added this to the Go1.16 milestone Aug 29, 2020
@aclements
Copy link
Member

It looks like the underlying problem here is that testprog TimeProf (the binary TestTimePprof runs) timed out. The "failed to fetch any source profiles" is a follow-on failure because the binary didn't exit. There's not much information about the time-out, unfortunately. We may want to add in a GOTRACEBACK=crash just to get more details.

@aclements
Copy link
Member

We had a brief cluster of these and they haven't shown up since:

2020-09-03T05:33:35-6c76ede/linux-amd64-longtest
2020-08-28T21:23:32-a58a8d2/linux-amd64
2020-08-28T20:01:41-54e18f1/linux-amd64

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/258802 mentions this issue: runtime: add debugging to TestTimePprof

gopherbot pushed a commit that referenced this issue Oct 2, 2020
@aclements
runtime: add debugging to TestTimePprof
d888f1d 
We've seen timeouts of TestTimePprof, but the tracebacks aren't useful
because goroutines are running on other threads. Add GOTRACEBACK=crash
to catch these in the future.

For #41120.

Change-Id: I97318172ef78d0cbab10df5e4ffcbfeadff579e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/258802
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2020 •
edited
Loading

This hasn't been happening lately and seems that it shouldn't be blocking the release anymore.

We should update the issue if something changes.

@bcmills bcmills mentioned this issue Dec 10, 2020
Closed
@aclements
Copy link
Member

According to greplogs -dashboard -e "failed to fetch any source profiles" -l, there haven't been any of these since 2020-09-03T05:33:35-6c76ede, so I'm calling this fixed.

@golang golang locked and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
4 participants
@dmitshur @aclements @bcmills @gopherbot