New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding/xml: make sure Encoder.Encode reports Write errors #4112
Labels
Milestone
Comments
We can't change the signature due to the API compatibility promise. We could introduce a second function. Note that the usual use of this is to write to a bytes.Buffer, and you can poll that after the fact for a write error by using buf.Write(nil). Labels changed: added priority-later, go1.1, removed priority-triage. Status changed to Accepted. |
I missed that this was about Escape, not Marshal. 1. Add tests that Marshal and Encoder.Encode return I/O errors. 2. Add EscapeText that is like Escape but returns error. 3. Make Escape the obvious wrapper - still dropping error. 4. Make Escape description: // Escape is like EscapeText but omits the error return value. // It is provided for backwards compatibility with Go 1.0. // Code targeting Go 1.1 or later should use EscapeText. |
Started by osaingre@gmail.com https://golang.org/cl/7085053/ Status changed to Started. |
This issue was closed by revision afde71c. Status changed to Fixed. |
gopherbot
added
fixed
Suggested
Issues that may be good for new contributors looking for work to do.
labels
Feb 20, 2013
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by justin@fathomdb.com:
The text was updated successfully, but these errors were encountered: