Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: package title in Package Details->Overview->Readme has inappropriate header level #41111

Closed
jba opened this issue Aug 28, 2020 · 1 comment
Closed

x/pkgsite: package title in Package Details->Overview->Readme has inappropriate header level #41111

jba opened this issue Aug 28, 2020 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@jba
Copy link
Contributor

jba commented Aug 28, 2020

The package title in <div class="Overview-readmeContainer"> is marked as an <h1> but should be an <h3> as a subheading of README which is <h2>. This also rectifies issues with subsequent headers within this div that are marked as <h4> missing their <h3>.
@jba jba added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input labels Aug 28, 2020
@jba jba added this to the pkgsite/frontend milestone Aug 28, 2020
@julieqiu julieqiu removed the UX Issues that involve UXD/UXR input label Sep 8, 2020
@jamalc jamalc self-assigned this Nov 18, 2020
@jamalc
Copy link

jamalc commented Nov 18, 2020

Fixed.

@jamalc jamalc closed this as completed Nov 18, 2020
@golang golang locked and limited conversation to collaborators Nov 18, 2021
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@hyangah @julieqiu @gopherbot @jamalc @jba