Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/cmd/gorelease: current and prior versions should not be considered valid #41110

Closed
jeanbza opened this issue Aug 28, 2020 · 3 comments
Closed

x/exp/cmd/gorelease: current and prior versions should not be considered valid #41110

jeanbza opened this issue Aug 28, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@jeanbza
Copy link
Member

jeanbza commented Aug 28, 2020 

deklerk at deklerk-macbookpro in ~/workspace/lean on garbage
$ git tag
v0.1.0
deklerk at deklerk-macbookpro in ~/workspace/lean on garbage
$ gorelease -version=v0.1.0
Inferred base version: none
v0.1.0 is a valid semantic version for this release.
$ gorelease -version=v0.0.1
Inferred base version: none
v0.1.0 is a valid semantic version for this release.

As you can see, gorelease is fine with a proposed version that is equivalent to an existing version, and a proposed version that is before an existing version. Most likely the issue is that it is not inferring the existing version.
@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2020
@cagedmantis cagedmantis added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Aug 31, 2020
@cagedmantis
Copy link
Contributor

/cc @jayconrod

@jayconrod
Copy link
Contributor

Let's consolidate this with #37562, which is pretty similar. I've added a note there that gorelease should report a diagnostic if an existing version is specified explicitly.

Prior versions are fine, as long as they don't already exist. For example, someone might tag a new minor release v1.4.0, then later tag new patch releases on an old branch v1.3.5, v1.3.6.

@jeanbza
Copy link
Member Author

jeanbza commented Aug 31, 2020

SGTM.

@jeanbza jeanbza closed this as completed Aug 31, 2020
@jeanbza jeanbza mentioned this issue Aug 31, 2020
Closed
@golang golang locked and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@cagedmantis @jayconrod @jeanbza @gopherbot