Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: several img tags lack descriptive alt text #41104

Closed
jba opened this issue Aug 28, 2020 · 3 comments
Closed

x/pkgsite: several img tags lack descriptive alt text #41104

jba opened this issue Aug 28, 2020 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@jba
Copy link
Contributor

jba commented Aug 28, 2020

Current alt text says "Go" which is fine, but adds no semantic content for screen reader users. "Go logo" would be preferable.
@jba jba added NeedsFix The path to resolution is known, but the work has not been done. pkgsite UX Issues that involve UXD/UXR input labels Aug 28, 2020
@jba jba added this to the pkgsite/unplanned milestone Aug 28, 2020
@jba
Copy link
Contributor Author

jba commented Aug 28, 2020

First comment applies to <img class=”NavigationDrawer-logo”> in header.

Also:

  • <img class=”Header-logo”> in header: use "Go logo"
  • <img class=”Footer-gopher”> in footer: use "Gopher in flight goggles"

@jba jba changed the title x/pkgsite: <img class=”NavigationDrawer-logo” in header lacks descriptive alt text x/pkgsite: several img tags lack descriptive alt text Aug 28, 2020
@jimmyfrasche
Copy link
Member

.Header-logo and .NavigationDrawer-logo are the sole contents of links so the alt text should describe the destination of the link.

.Footer-gopher is purely decorative so its alt text should (explicitly) be the empty string.

@julieqiu julieqiu removed the UX Issues that involve UXD/UXR input label Sep 8, 2020
@gopherbot
Copy link

Change https://golang.org/cl/275938 mentions this issue: x/pgksite: several img tags lack descriptive alt text

@golang golang locked and limited conversation to collaborators Dec 15, 2021
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@jimmyfrasche @hyangah @julieqiu @gopherbot @jba