Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: allow using repository url as search query #41095

Closed
icholy opened this issue Aug 28, 2020 · 3 comments
Closed

x/pkgsite: allow using repository url as search query #41095

icholy opened this issue Aug 28, 2020 · 3 comments
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/frontend

Comments

@icholy
Copy link

icholy commented Aug 28, 2020

What did you do?

Copied a github url and pasted it in the search bar.

https://pkg.go.dev/search?q=https://github.com/icholy/utm

What did you expect to see?

I expected it to behave like godoc.org and bring me to the package documentation.

https://godoc.org/?q=https://github.com/icholy/utm

What did you see instead?

0 results found
@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2020
@cagedmantis
Copy link
Contributor

/cc @julieqiu @jba @jamalc

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Aug 28, 2020
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 28, 2020
@gopherbot
Copy link

Change https://golang.org/cl/254371 mentions this issue: internal/frontend: Trim URL scheme in search query

@jba jba mentioned this issue Sep 15, 2020
Closed
@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
gopherbot pushed a commit to golang/pkgsite that referenced this issue Oct 2, 2020
internal/frontend: trim URL scheme in search query
64371af 
This change removes the url scheme in the beginning of a search query to
allow the use of full repository urls to directly redirect to the
documentation page.

Example Behavior: https://photos.app.goo.gl/THDyCV2juVLasaVP6

Updates golang/go#41095

Change-Id: I951aa634529aa554edac12487d333106e2d52fe9
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/254371
Trust: Miguel Acero <acero@google.com>
Run-TryBot: Miguel Acero <acero@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@icholy
Copy link
Author

icholy commented Oct 14, 2020

I believe this can be closed.

@golang golang locked and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
4 participants
@cagedmantis @icholy @julieqiu @gopherbot