Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: forward slash does not initiate find in page on Firefox #41093

Closed
emilal opened this issue Aug 28, 2020 · 3 comments
Closed

x/pkgsite: forward slash does not initiate find in page on Firefox #41093

emilal opened this issue Aug 28, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/frontend

Comments

@emilal
Copy link

emilal commented Aug 28, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/k8s.io/client-go/kubernetes?tab=doc

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Screenshot

Screenshot_2020-08-28 kubernetes package · pkg go dev

What did you do?

Used the '/' key

What did you expect to see?

Firefox' "find in page"

What did you see instead?

Nothing. Something on the site seems to break '/' searching. (It was also broken on godoc.org, where it highlighted a search box that didn't search in the page.)
@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2020
@cagedmantis cagedmantis changed the title x/pkgsite: x/pkgsite: forward slash does not initiate find in page on Firefox Aug 28, 2020
@cagedmantis cagedmantis added pkgsite NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 28, 2020
@cagedmantis
Copy link
Contributor

/cc @julieqiu @jba @jamalc

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Aug 28, 2020
@gopherbot
Copy link

Change https://golang.org/cl/252117 mentions this issue: content/static: fixes search input focus and supports quickfind in Firefox

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 1, 2020
@jamalc
content/static: fixes search input focus and supports quickfind in Fi…
3b43f75 
…refox

Fixes search input focus key on detail pages and removes the behavior
in Firefox to support quickfind.

Updates golang/go#41093

Change-Id: Iae0c8fdde0df592e7f9eeac37183b27231bb441c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/252117
Reviewed-by: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
@jamalc
Copy link

jamalc commented Oct 1, 2020

Fixed

@jamalc jamalc closed this as completed Oct 1, 2020
@golang golang locked and limited conversation to collaborators Oct 1, 2021
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@cagedmantis @julieqiu @gopherbot @emilal @jamalc