x/tools/gopls: fails to load package for test file #41081
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
gopherbot
added
Tools
dylankb
changed the title
dylankb
changed the title
|
The second issue you mention is #40690. The issue with your test file is that |
stamblerre
changed the title
|
Yes, the test files do use build tags. Should build tags be handled in gopls settings?. Here's the output you requested.
Perhaps it's a problem that these files show up as |
|
Yes - you have to add build tags to your configuration if you are using a build tagged file. |
|
The setting you want is: "gopls": {
"env": {
"GOFLAGS": "-tags=<my build tag>"
}
} |
|
Wohoo! Totally fixes my issue. Great project, and I also loved your GopherCon talk. Keep it up! |
|
Thank you! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
VSCode fails to execute commands such as "Go to Definition" while using gopls on my machine for
*_test.gofiles. In other words, it does not reveal the requested source code or preview for the command. Additionally, I see gopls server error logs when I open any of these files in my VSCode editor and when usinggopls check. This is not the case in non-test files in the same packages.What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (
go env)?go envOutputgopls related VSCode settings
{ ... "go.useLanguageServer": true, "[go]": { "editor.formatOnSave": true, "editor.codeActionsOnSave": { "source.organizeImports": true, }, // Optional: Disable snippets, as they conflict with completion ranking. "editor.snippetSuggestions": "none", }, "[go.mod]": { "editor.formatOnSave": true, "editor.codeActionsOnSave": { "source.organizeImports": true, }, }, "gopls": { // Add parameter placeholders when completing a function. "usePlaceholders": true, // If true, enable additional analyses with staticcheck. // Warning: This will significantly increase memory usage. "staticcheck": false, }, "go.languageServerFlags": [ "-rpc.trace", // for more detailed debug logging "serve", "--debug=localhost:6060", // to investigate memory usage, see profiles ], }What did you do?
I'm not certain when or if a breakage occurred since other editors are in use on my team, but I can try to reproduce a more minimal example if this information is not enough.
What did you expect to see?
When I navigate to a file I don't expect to see RPC trace errors for the gopls server. For example, navigating to an
/internal/db_test.gofile. When I navigate to/internal/db.go, I do not see these errors.When I click
Go to DefinitionI expect the editor to navigate to the source code at defined either in the temporary modules cache or a file within the project directory. I also don't expect to see gopls errors in the RPC trace when hovering or clicking Go.Similarly, I expect
gopls checkto not return errors for test files - no errors for non-test files.gopls check /Users/dbarnard/Code/go/src/$MY_PRIVATE_REPO/$MY_PROJECT/internal/db/db.goWhat did you see instead?
When I navigate to an
*_test.gofile, I see RPC and see trace errors in the gopls server. Here I'm navigating to an/internal/db_test.gofile.When I right click on a symbol defined in an external package (outside of the project repository) in
*_test.gofile, I see "No definition found for ..." any symbol in the VSCode editor. The traces for gopls server RPC trace errors are below.Here
gopls checkdoes return an errorFinally, this may be a separate issue but just in case it helps as context -- I seem get this error as a popup from the VSCode Go extension/gopls when I add a new package in my source code and save. Example:
Thanks in advance!
The text was updated successfully, but these errors were encountered: