Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: test failure on mod_sumdb_file_path on module retraction CLs #41078

Closed
jayconrod opened this issue Aug 27, 2020 · 2 comments
Closed

cmd/go: test failure on mod_sumdb_file_path on module retraction CLs #41078

jayconrod opened this issue Aug 27, 2020 · 2 comments
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.16

Comments

@jayconrod
Copy link
Contributor

After I submitted the module retraction CLs yesterday (ending with CL 228384), I noticed a few test failures on the long test builders in the middle of the series:

The failure looks like this:

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_sumdb_file_path (2.02s)
        script_test.go:211: 
            # With a file-based proxy with an empty checksum directory,
            # downloading a new module should fail, even if a subsequent
            # proxy contains a more complete mirror of the sum database.
            #
            # TODO(bcmills): The error message here is a bit redundant.
            # It comes from the sumweb package, which isn't yet producing structured errors. (0.801s)
            # If the proxy does not claim to support the database,
            # checksum verification should fall through to the next proxy,
            # and downloading should succeed. (1.182s)
            # After a successful sumdb lookup, the lookup can be repeated
            # using the download cache as a proxy. (0.011s)
            > cp supported $GOPATH/pkg/mod/cache/download/sumdb/sum.golang.org/supported
            > [windows] env GOPROXY=file:///$WORK/gopath1/pkg/mod/cache/download,file:///$WORK/sumproxy
            > [!windows] env GOPROXY=file://$WORK/gopath1/pkg/mod/cache/download,file://$WORK/sumproxy
            > env GOPATH=$WORK/gopath2
            > rm go.sum
            > go get -d -x -v golang.org/x/text@v0.3.2
            [stderr]
            go: golang.org/x/text@v0.3.2 (replaced by golang.org/x/text@v0.3.2/go.mod): verifying module: golang.org/x/text@v0.3.2/go.mod: reading file://$WORK/gopath1/pkg/mod/cache/download/sumdb/sum.golang.org/tile/8/0/x006/108.p/150: no such file or directory
            [exit status 1]
            FAIL: testdata/script/mod_sumdb_file_path.txt:32: unexpected command failure

Essentially, the test is running go get -d golang.org/x/text@v0.3.2 with an empty module cache. It then deletes go.sum and uses the old module cache as a proxy with sumdb support and runs the same command again.

The error indicates the local sumdb lookup was successful, but the tile was missing. I'm not sure why that would happen. Both commands should retrieve the same set of tiles. The first command should fail if it wasn't able to retrieve a tile. The second command should succeed if the tile is present.

The error stopped happening after CL 228383. That might cause new tiles to be fetched for v0.3.3, but it shouldn't affect whether a tile is fetched for v0.3.2. The error didn't happen consistently across builders, and I haven't been able to reproduce it, either locally or with a linux-amd64 gomote.
@jayconrod jayconrod added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. modules labels Aug 27, 2020
@jayconrod jayconrod added this to the Go1.16 milestone Aug 27, 2020
@jayconrod jayconrod self-assigned this Aug 27, 2020
@jayconrod
Copy link
Contributor Author

cc @bcmills @matloob

@jayconrod
Copy link
Contributor Author

Was never able to reproduce this, and it hasn't showed up in the logs, so closing this issue.

@golang golang locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot